Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multiple nested envelop extension duplicating plugins #1944

Merged
merged 4 commits into from
Sep 27, 2023
Merged

fix multiple nested envelop extension duplicating plugins #1944

merged 4 commits into from
Sep 27, 2023

Conversation

EmrysMyrddin
Copy link
Collaborator

Description

Fixes a bug where using multiple nested envelop extensions duplicates the plugins of the nested instances.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 3f34d56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/core 4.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/apollo-datasources 3.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/apollo-federation 4.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/apollo-server-errors 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/apollo-tracing 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/auth0 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/dataloader 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/depth-limit 3.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/disable-introspection 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/execute-subscription-event 4.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/extended-validation 3.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/filter-operation-type 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/fragment-arguments 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/generic-auth 6.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/graphql-jit 6.0.3-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/graphql-middleware 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/graphql-modules 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/immediate-introspection 2.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/live-query 6.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/newrelic 6.0.3-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/on-resolve 3.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/opentelemetry 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/operation-field-permissions 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/parser-cache 6.0.3-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/persisted-operations 6.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/preload-assets 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/prometheus 8.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/rate-limiter 5.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/resource-limitations 4.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/response-cache 5.3.1-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/response-cache-redis 3.3.1-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/sentry 6.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/statsd 4.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/validation-cache 6.0.3-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎
@envelop/testing 6.0.2-alpha-20230915095429-a92ff55d npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023 •
edited
Loading

💻 Website Preview

The latest changes are available as preview in: https://b880917d.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Sep 15, 2023 •
edited
Loading

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 559696      ✗ 0     
     data_received......................................: 2.1 GB  14 MB/s
     data_sent..........................................: 122 MB  811 kB/s
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.36µs  min=700ns    med=1.4µs   max=8.02ms  p(90)=2.2µs   p(95)=2.6µs  
     http_req_connecting................................: avg=205ns   min=0s       med=0s      max=6.6ms   p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=5.03ms  min=218.8µs  med=3.57ms  max=87.78ms p(90)=9.38ms  p(95)=16.84ms
       { expected_response:true }.......................: avg=5.03ms  min=218.8µs  med=3.57ms  max=87.78ms p(90)=9.38ms  p(95)=16.84ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=4.29ms  min=468.4µs  med=3.77ms  max=57.99ms p(90)=6.9ms   p(95)=8.34ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=2.73ms  min=218.8µs  med=2.39ms  max=24.5ms  p(90)=4.37ms  p(95)=5.86ms 
     ✓ { mode:envelop-just-cache }......................: avg=4.25ms  min=404.5µs  med=3.64ms  max=64.76ms p(90)=6.97ms  p(95)=8.62ms 
     ✓ { mode:graphql-js }..............................: avg=7.86ms  min=779.41µs med=6.66ms  max=67.85ms p(90)=12.81ms p(95)=14.42ms
     ✓ { mode:prom-tracing }............................: avg=20ms    min=4.62ms   med=17.81ms max=87.78ms p(90)=33.57ms p(95)=35.74ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 279848
     http_req_receiving.................................: avg=43.34µs min=13.2µs   med=24µs    max=12.97ms p(90)=36.8µs  p(95)=43.7µs 
     http_req_sending...................................: avg=34.29µs min=4.89µs   med=8.3µs   max=18.47ms p(90)=15.5µs  p(95)=23.4µs 
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.95ms  min=180.1µs  med=3.51ms  max=87.71ms p(90)=9.08ms  p(95)=16.69ms
     http_reqs..........................................: 279848  1865.533475/s
     iteration_duration.................................: avg=5.35ms  min=471.5µs  med=3.88ms  max=88.11ms p(90)=9.94ms  p(95)=17.24ms
     iterations.........................................: 279848  1865.533475/s
     vus................................................: 10      min=10        max=20  
     vus_max............................................: 20      min=20        max=20

@ardatan ardatan merged commit db20864 into main Sep 27, 2023
17 of 18 checks passed
@theguild-bot theguild-bot mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmrysMyrddin @theguild-bot @ardatan