Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [plugins/sentry] update to Sentry v8 #2335

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: [plugins/sentry] update to Sentry v8 #2335

merged 2 commits into from
Dec 2, 2024

Conversation

EmrysMyrddin
Copy link
Collaborator

Description

The Sentry plugin, while it denpends on Sentry v8, never got updated to use the new APIs introduced by this major version.

For some reason, the testkit still works with the old API, but it doesn't actually work in real world usage.

Fixes #2193

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: f0f8413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/sentry Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 28, 2024

💻 Website Preview

The latest changes are available as preview in: https://86d7a54f.envelop.pages.dev

@theguild-bot
Copy link
Collaborator

theguild-bot commented Nov 28, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 762782      ✗ 0     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: 100.00% ✓ 164534      ✗ 0     
     ✓ { mode:envelop-cache-jit }.......................: 100.00% ✓ 331778      ✗ 0     
     ✓ { mode:envelop-just-cache }......................: 100.00% ✓ 164114      ✗ 0     
     ✓ { mode:graphql-js }..............................: 100.00% ✓ 102356      ✗ 0     
     data_received......................................: 2.9 GB  24 MB/s
     data_sent..........................................: 166 MB  1.4 MB/s
     envelop_init.......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     envelop_total......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     event_loop_lag.....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_execute....................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_parse......................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_validate...................................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_blocked...................................: avg=2.83µs  min=1.26µs   med=2.62µs  max=3.98ms  p(90)=3.44µs  p(95)=3.8µs  
     http_req_connecting................................: avg=44ns    min=0s       med=0s      max=2.33ms  p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=2.86ms  min=162.35µs med=2.79ms  max=40.39ms p(90)=5.15ms  p(95)=6.08ms 
       { expected_response:true }.......................: avg=2.86ms  min=162.35µs med=2.79ms  max=40.39ms p(90)=5.15ms  p(95)=6.08ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.37ms  min=407.14µs med=3.02ms  max=17.5ms  p(90)=5.7ms   p(95)=6.2ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=1.5ms   min=162.35µs med=1.25ms  max=16.66ms p(90)=2.52ms  p(95)=2.67ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.38ms  min=446.65µs med=3.01ms  max=23.18ms p(90)=5.69ms  p(95)=6.2ms  
     ✓ { mode:graphql-js }..............................: avg=5.58ms  min=726.86µs med=4.82ms  max=40.39ms p(90)=9.35ms  p(95)=10.11ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 381391
     http_req_receiving.................................: avg=35.55µs min=13.11µs  med=30.88µs max=11.34ms p(90)=46.9µs  p(95)=50.52µs
     http_req_sending...................................: avg=12.61µs min=3.9µs    med=9.99µs  max=14.66ms p(90)=19.64µs p(95)=20.8µs 
     http_req_tls_handshaking...........................: avg=0s      min=0s       med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=2.81ms  min=134.15µs med=2.74ms  max=40.31ms p(90)=5.09ms  p(95)=6.03ms 
     http_reqs..........................................: 381391  3178.175723/s
     iteration_duration.................................: avg=3.13ms  min=362.05µs med=3.04ms  max=41.52ms p(90)=5.43ms  p(95)=6.37ms 
     iterations.........................................: 381391  3178.175723/s
     vus................................................: 10      min=10        max=10  
     vus_max............................................: 20      min=20        max=20  

Copy link
Contributor

github-actions bot commented Dec 2, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@envelop/sentry 11.0.0-alpha-20241202082807-f0f8413390223bc5a8ad7a500546aa9d5256c7df npm ↗︎ unpkg ↗︎

@ardatan ardatan merged commit 073774c into main Dec 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sentry v8 compatible integration
3 participants