Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creation of BIN_DIR before extracting archive #14

Merged
merged 1 commit into from
May 23, 2023
Merged

Add creation of BIN_DIR before extracting archive #14

merged 1 commit into from
May 23, 2023

Conversation

jonathanio
Copy link
Contributor

Add the creation of the BIN_DIR before extracting the archive and it is an ignored directory and may not be present when the script is run.

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

@jonathanio
Add creation of BIN_DIR before extracting archive
7afd7ef 
Add the creation of the BIN_DIR before extracting the archive and it is
an ignored directory and may not be present when the script it run.
@jonathanio jonathanio added priority/medium This is a medium-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/scripts Update with changes to scripts labels May 23, 2023
@jonathanio jonathanio requested a review from a team as a code owner May 23, 2023 15:38
@jonathanio jonathanio self-assigned this May 23, 2023
@jonathanio jonathanio merged commit 4a49693 into main May 23, 2023
@jonathanio jonathanio deleted the add-bin-dir-creation branch May 23, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanio jonathanio

Labels
priority/medium This is a medium-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/scripts Update with changes to scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathanio