Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update --label-prefixes-any flag for prefixes check to --label-prefix-mode option #19

Merged
merged 1 commit into from
May 29, 2023
Merged

Update --label-prefixes-any flag for prefixes check to --label-prefix-mode option #19

merged 1 commit into from
May 29, 2023

Conversation

jonathanio
Copy link
Contributor

Update the --label-prefixes-any flag for the application to --label-prefix-mode with an argument to allow selection between any and all. This should make it easier to use and configure, and to expand upon in the future, if required.

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

@jonathanio
Update any flag for prefixes check to mode option
4b21d60 
Update the label-prefixes-any flag for the application to
label-prefix-mode with an argument to allow selection between any and
all. This should make it easier to use and configure, and to expand
upon in the future, if required.
@jonathanio jonathanio added priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request type/refactoring A refactoring of existing code update/github-action Update with changes to the GitHub Action update/go Update with changes to Go files or applications labels May 29, 2023
@jonathanio jonathanio self-assigned this May 29, 2023
@jonathanio jonathanio requested a review from a team as a code owner May 29, 2023 00:51
@jonathanio jonathanio enabled auto-merge (rebase) May 29, 2023 00:51
@jonathanio jonathanio merged commit 6002e12 into main May 29, 2023
@jonathanio jonathanio deleted the update-prefixes-to-mode branch May 29, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanio jonathanio

Labels
priority/normal This is a normal-priority issue or pull request release/update An update to an existing feature is made with this pull request type/refactoring A refactoring of existing code update/github-action Update with changes to the GitHub Action update/go Update with changes to Go files or applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathanio