Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking pull request assignees #21

Merged
merged 3 commits into from
May 30, 2023

Conversation

jonathanio
Copy link
Contributor

Add the initial code to check for any assignees on the pull request, and add the owner of the pull request to the assignees if none have been set.

Part Of: #1

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

Change the working for the two minimum options to remove the word
minimum and make them more specific as to their purpose.
@jonathanio jonathanio added priority/high This is a high-priority issue or pull reqest release/feature A new feature is added with this pull request type/enhancement Adding or requesting a new feature update/documentation Update with improvements to the documentation update/github-action Update with changes to the GitHub Action update/go Update with changes to Go files or applications labels May 29, 2023
@jonathanio jonathanio self-assigned this May 29, 2023
@jonathanio jonathanio requested a review from a team as a code owner May 29, 2023 21:30
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #21 (cd10e3c) into main (0dec776) will increase coverage by 1.63%.
The diff coverage is 44.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   46.19%   47.82%   +1.63%     
==========================================
  Files           5        6       +1     
  Lines         184      230      +46     
==========================================
+ Hits           85      110      +25     
- Misses         99      119      +20     
- Partials        0        1       +1     
Impacted Files Coverage Δ
internal/action/main.go 0.00% <0.00%> (ø)
internal/github/main.go 0.00% <0.00%> (ø)
internal/action/check_assignee.go 89.28% <89.28%> (ø)

Add the initial code to check for any assignees on the pull request, and
add the owner of the pull request to the assignees if none have been
set.
Clean up the comments and the logs for the checks and tests so they are
correct and/or more relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high This is a high-priority issue or pull reqest release/feature A new feature is added with this pull request type/enhancement Adding or requesting a new feature update/documentation Update with improvements to the documentation update/github-action Update with changes to the GitHub Action update/go Update with changes to Go files or applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create standard GitHub Action for checking and automating pull request checks
1 participant