Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the binary name for pull-requester in Dockerfile #6

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix the binary name for pull-requester in Dockerfile #6

merged 2 commits into from
May 18, 2023

Conversation

jonathanio
Copy link
Contributor

@jonathanio jonathanio commented May 18, 2023 •
edited
Loading

Fix the name of the binary for pull-requester in the Dockerfile, which was incorrectly truncated.

Checklist

Please confirm the following checks:

  • My pull request follows the guidelines set out in CONTRIBUTING.md.
  • I have performed a self-review of my code and run any tests locally to check.
  • I have added tests that prove my changes are effective and work correctly.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my code and corrected any misspellings.
  • Each commit in this pull request has a meaningful subject & body for context.
  • I have squashed all "fix(up)" commits to provide a clean code history.
  • My pull request has an appropriate title and description for context.
  • I have linked this pull request to other issues or pull requests as needed.
  • I have added type/..., changes/..., and 'release/...' labels as needed.

@jonathanio
Fix the binary name for pull-requester in Dockerfile
2a55acb 
Fix the name of the binary for pull-requester in the Dockerfile, which
was incorrectly truncated.
@jonathanio jonathanio added priority/high This is a high-priority issue or pull reqest release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/configuration Update with changes to tool or service configuratons labels May 18, 2023
@jonathanio jonathanio self-assigned this May 18, 2023
@jonathanio jonathanio requested a review from a team as a code owner May 18, 2023 23:07
@jonathanio
Fix the path to the docker image for the Action
8bd87d8 
Fix the path to the docker image for the GitHub Action as it needs to be
prefixed with docker://
@jonathanio jonathanio merged commit fb05a06 into main May 18, 2023
@jonathanio jonathanio deleted the fix-pull-requester-binary branch May 18, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanio jonathanio

Labels
priority/high This is a high-priority issue or pull reqest release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/configuration Update with changes to tool or service configuratons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathanio