Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path label to better handle 404 requests #15

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jonathanio
Copy link
Contributor

Update the processing of the path label to move an empty path to a 404 value, to better represent that the path was not found by a handler, but processed by the NotFound handler instead.

Checklist

Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:

  • I have performed a self-review of my code and run any tests locally to check
  • I have added tests that prove that any changes are effective and work correctly
  • I have made corresponding changes, as needed, to the repository documentation
  • Each commit in, and this pull request, have meaningful subjects and bodies for context
  • I have added release/..., type/..., and changes/... labels, as needed, to this pull request

Update the processing of the path label to move an empty path to a 404
value, to better represent that the path was not found by a handler, but
processed by the NotFound handler instead.
@jonathanio jonathanio added priority/normal This is a normal-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/go Update with changes to Go files or applications labels Aug 15, 2024
@jonathanio jonathanio self-assigned this Aug 15, 2024
@jonathanio jonathanio merged commit 4b120e2 into main Aug 15, 2024
10 checks passed
@jonathanio jonathanio deleted the refactor-prometheus-metrics branch August 15, 2024 21:28
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.70%. Comparing base (a6ff104) to head (277dfb7).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/serve/middleware/prometheus.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #15      +/-   ##
========================================
- Coverage   9.74%   9.70%   -0.04%     
========================================
  Files         17      17              
  Lines        513     515       +2     
========================================
  Hits          50      50              
- Misses       463     465       +2     
Flag Coverage Δ
unit-tests 9.70% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/serve/middleware/prometheus.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/normal This is a normal-priority issue or pull request release/fix A fix for a bug or identified issue with this pull request type/bug Something is not working correctly update/go Update with changes to Go files or applications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant