Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webPort reference in Ingress resource #9

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

jonathanio
Copy link
Contributor

Fix the webPort reference in the Ingress resource as the web port for Ingress was pointing at the old configuration and therefore no longer valid.

Checklist

Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:

  • I have performed a self-review of my code and run any tests locally to check
  • I have added tests that prove that any changes are effective and work correctly
  • I have made corresponding changes, as needed, to the repository documentation
  • Each commit in, and this pull request, have meaningful subjects and bodies for context
  • I have added release/..., type/..., and changes/... labels, as needed, to this pull request

Fix the webPort reference in the Ingress resource as the web port for
Ingress was pointing at the old configuration and therefore no longer
valid.
@jonathanio jonathanio added priority/high This is a high-priority issue or pull reqest release/fix A fix for a bug or identified issue with this pull request update/helm Update with changes to the Helm charts labels Aug 14, 2024
@jonathanio jonathanio self-assigned this Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.16%. Comparing base (dc3d635) to head (4ce6d78).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main       #9       +/-   ##
=========================================
+ Coverage      0   10.16%   +10.16%     
=========================================
  Files         0       17       +17     
  Lines         0      492      +492     
=========================================
+ Hits          0       50       +50     
- Misses        0      442      +442     
Flag Coverage Δ
unit-tests 10.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

@jonathanio jonathanio merged commit a5b1287 into main Aug 14, 2024
11 checks passed
@jonathanio jonathanio deleted the fix-ingress-port branch August 14, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high This is a high-priority issue or pull reqest release/fix A fix for a bug or identified issue with this pull request update/helm Update with changes to the Helm charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant