Provide access to stack traces of arbitrary size in extended data items. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current StackTrace32(_) and StackTrace64(_) definitions yield a value of the inner item type exposed by the windows crate. This type is autogenerated from the C definition, which uses an ANYSIZE_ARRAY (a constant defined as 1). As a side effect, a value of the autogenerated Rust type can only contain a single address from the captured call stack. * Define a custom type usable as StackTraceItem<u32> and StackTraceItem<u64> to represent captured call stacks of arbitrary size. * Make StackTrace32(_) and StackTrace64(_) yield values of this new custom type.
|
Example of using the new |
n4r1b
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
StackTrace32(_)andStackTrace64(_)definitions yield a value of the inner item type exposed by thewindowscrate. This type is autogenerated from the C definition, which uses anANYSIZE_ARRAY(a constant defined as1). As a side effect, a value of the autogenerated Rust type can only contain a single address from the captured call stack.Define a custom type usable as
StackTraceItem<u32>andStackTraceItem<u64>to represent captured call stacks of arbitrary size.Make
StackTrace32(_)andStackTrace64(_)yield values of this new custom type.