Remove unused legacy token BrokenResolvable
and cleanup
#2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BrokenResolvable
token was added to support a requirement that was later dropped, so this token is unused. I'm not clear on whyBrokenResolvable
is currently causing so many tests to fail onmaster
. I wrote tests specifically for this token and Codemirror's test harness does not allow running a subset of tests, therefore I expect these were all passing back when v1 of this lib was released. But there was no CI to block merging in case of failing tests. In any case, this token is unneeded, so we can remove and simplify.Once this lib is in the monorepo, regressions will be caught by
test
script runs.