fix(Linear Node): Fix issue with data not always being returned (#9273)

Co-authored-by: Michael Kret <michael.k@radency.com>
n8n-io · May 8, 2024 · 435272b · 435272b
1 parent 3860077
commit 435272b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/packages/nodes-base/nodes/Linear/GenericFunctions.ts b/packages/nodes-base/nodes/Linear/GenericFunctions.ts
@@ -52,20 +52,30 @@ export function capitalizeFirstLetter(data: string) {
 export async function linearApiRequestAllItems(
 	this: IHookFunctions | IExecuteFunctions | ILoadOptionsFunctions,
 	propertyName: string,
-
 	body: any = {},
+	limit?: number,
 ): Promise<any> {
 	const returnData: IDataObject[] = [];
 
 	let responseData;
-	body.variables.first = 50;
+	body.variables.first = limit && limit < 50 ? limit : 50;
 	body.variables.after = null;
 
+	const propertyPath = propertyName.split('.');
+	const nodesPath = [...propertyPath, 'nodes'];
+	const endCursorPath = [...propertyPath, 'pageInfo', 'endCursor'];
+	const hasNextPagePath = [...propertyPath, 'pageInfo', 'hasNextPage'];
+
 	do {
 		responseData = await linearApiRequest.call(this, body);
-		returnData.push.apply(returnData, get(responseData, [propertyName, 'nodes']) as IDataObject[]);
-		body.variables.after = get(responseData, [propertyName, 'pageInfo', 'endCursor']);
-	} while (get(responseData, [propertyName, 'pageInfo', 'hasNextPage']));
+		const nodes = get(responseData, nodesPath) as IDataObject[];
+		returnData.push(...nodes);
+		body.variables.after = get(responseData, endCursorPath);
+		if (limit && returnData.length >= limit) {
+			return returnData;
+		}
+	} while (get(responseData, hasNextPagePath));
+
 	return returnData;
 }
 

diff --git a/packages/nodes-base/nodes/Linear/IssueDescription.ts b/packages/nodes-base/nodes/Linear/IssueDescription.ts
@@ -192,7 +192,6 @@ export const issueFields: INodeProperties[] = [
 		default: 50,
 		typeOptions: {
 			minValue: 1,
-			maxValue: 300,
 		},
 		displayOptions: {
 			show: {

diff --git a/packages/nodes-base/nodes/Linear/Linear.node.ts b/packages/nodes-base/nodes/Linear/Linear.node.ts
@@ -272,9 +272,7 @@ export class Linear implements INodeType {
 							responseData = await linearApiRequestAllItems.call(this, 'data.issues', body);
 						} else {
 							const limit = this.getNodeParameter('limit', 0);
-							body.variables.first = limit;
-							responseData = await linearApiRequest.call(this, body);
-							responseData = responseData.data.issues.nodes;
+							responseData = await linearApiRequestAllItems.call(this, 'data.issues', body, limit);
 						}
 					}
 					if (operation === 'update') {