⚡ keepAlive always on

n8n-io · Apr 8, 2024 · 6348021 · 6348021
1 parent 8b39f72
commit 6348021
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 24 deletions.
diff --git a/packages/nodes-base/nodes/Postgres/PostgresTrigger.functions.ts b/packages/nodes-base/nodes/Postgres/PostgresTrigger.functions.ts
@@ -90,7 +90,6 @@ export async function initDB(this: ITriggerFunctions | ILoadOptionsFunctions) {
 	const options = this.getNodeParameter('options', {}) as {
 		connectionTimeout?: number;
 		delayClosingIdleConnection?: number;
-		keepAlive?: boolean;
 	};
 	const pgp = pgPromise({
 		// prevent spam in console "WARNING: Creating a duplicate database object for the same connection."
@@ -102,16 +101,13 @@ export async function initDB(this: ITriggerFunctions | ILoadOptionsFunctions) {
 		database: credentials.database as string,
 		user: credentials.user as string,
 		password: credentials.password as string,
+		keepAlive: true,
 	};
 
 	if (options.connectionTimeout) {
 		config.connectionTimeoutMillis = options.connectionTimeout * 1000;
 	}
 
-	if (options.keepAlive) {
-		config.keepAlive = options.keepAlive;
-	}
-
 	if (options.delayClosingIdleConnection) {
 		config.keepAliveInitialDelayMillis = options.delayClosingIdleConnection * 1000;
 	}

diff --git a/packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts b/packages/nodes-base/nodes/Postgres/PostgresTrigger.node.ts
@@ -234,13 +234,6 @@ export class PostgresTrigger implements INodeType {
 							minValue: 0,
 						},
 					},
-					{
-						displayName: 'Keep Alive',
-						name: 'keepAlive',
-						type: 'boolean',
-						default: false,
-						description: 'Whether to keep the connection alive',
-					},
 				],
 			},
 		],

diff --git a/packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts b/packages/nodes-base/nodes/Postgres/v2/actions/common.descriptions.ts
@@ -40,13 +40,6 @@ export const optionsCollection: INodeProperties = {
 				minValue: 0,
 			},
 		},
-		{
-			displayName: 'Keep Alive',
-			name: 'keepAlive',
-			type: 'boolean',
-			default: false,
-			description: 'Whether to keep the connection alive',
-		},
 		{
 			displayName: 'Query Batching',
 			name: 'queryBatching',

diff --git a/packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts b/packages/nodes-base/nodes/Postgres/v2/helpers/interfaces.ts
@@ -42,7 +42,6 @@ export type PostgresNodeOptions = {
 	cascade?: boolean;
 	connectionTimeout?: number;
 	delayClosingIdleConnection?: number;
-	keepAlive?: boolean;
 	queryBatching?: QueryMode;
 	queryReplacement?: string;
 	outputColumns?: string[];

diff --git a/packages/nodes-base/nodes/Postgres/v2/transport/index.ts b/packages/nodes-base/nodes/Postgres/v2/transport/index.ts
@@ -72,16 +72,13 @@ export async function configurePostgres(
 		database: credentials.database,
 		user: credentials.user,
 		password: credentials.password,
+		keepAlive: true,
 	};
 
 	if (options.connectionTimeout) {
 		dbConfig.connectionTimeoutMillis = options.connectionTimeout * 1000;
 	}
 
-	if (options.keepAlive) {
-		dbConfig.keepAlive = options.keepAlive;
-	}
-
 	if (options.delayClosingIdleConnection) {
 		dbConfig.keepAliveInitialDelayMillis = options.delayClosingIdleConnection * 1000;
 	}