✨ Updating automatic credentials position logic (removing `getParamet…

…erResolveOrder`call and fixing input spacing).
n8n-io · Jun 7, 2022 · 657e100 · 657e100
1 parent 0210773
commit 657e100
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/packages/editor-ui/src/components/NodeCredentials.vue b/packages/editor-ui/src/components/NodeCredentials.vue
@@ -315,6 +315,10 @@ export default mixins(
 <style lang="scss" module>
 .container {
 	margin-top: var(--spacing-xs);
+
+	& > div:not(:first-child) {
+		margin-top: var(--spacing-xs);
+	}
 }
 
 .warning {

diff --git a/packages/editor-ui/src/components/ParameterInputList.vue b/packages/editor-ui/src/components/ParameterInputList.vue
@@ -88,8 +88,6 @@
 import {
 	INodeParameters,
 	INodeProperties,
-	INodeTypeDescription,
-	NodeHelpers,
 	NodeParameterValue,
 } from 'n8n-workflow';
 
@@ -131,21 +129,14 @@ export default mixins(
 			node (): INodeUi {
 				return this.$store.getters.activeNode;
 			},
-			nodeType () : INodeTypeDescription {
-				return this.$store.getters.nodeType(this.node.type, this.node.typeVersion);
-			},
 			indexToShowSlotAt (): number {
 				let index = 0;
-				const paramDependencies = NodeHelpers.getParamterDependencies(this.nodeType.properties);
-				const paramOrder = NodeHelpers.getParamterResolveOrder(this.nodeType.properties, paramDependencies);
-
 				// Make sure credentials slot always appears below the last authentication field
 				this.filteredParameters.forEach((prop, propIndex) => {
 					if (prop.name.toLowerCase().endsWith('authentication')) {
-						index = paramOrder[propIndex] + 1;
+						index = propIndex + 1;
 					}
 				});
-
 				return index < this.filteredParameters.length ?
 					index : this.filteredParameters.length - 1;
 			},