fix(core): Validate numeric ids in the public API (#5251)

This was incorrectly changed in #5041
n8n-io · Jan 26, 2023 · 68e4083 · 68e4083
1 parent c8a146b
commit 68e4083
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 16 deletions.
diff --git a/packages/cli/src/PublicApi/v1/handlers/credentials/spec/paths/credentials.id.yml b/packages/cli/src/PublicApi/v1/handlers/credentials/spec/paths/credentials.id.yml
@@ -12,7 +12,7 @@ delete:
       description: The credential ID that needs to be deleted
       required: true
       schema:
-        type: string
+        type: number
   responses:
     '200':
       description: Operation successful.

diff --git a/packages/cli/src/PublicApi/v1/handlers/credentials/spec/schemas/credential.yml b/packages/cli/src/PublicApi/v1/handlers/credentials/spec/schemas/credential.yml
@@ -5,9 +5,9 @@ required:
 type: object
 properties:
   id:
-    type: string
+    type: number
     readOnly: true
-    example: '42'
+    example: 42
   name:
     type: string
     example: Joe's Github Credentials

diff --git a/packages/cli/src/PublicApi/v1/handlers/executions/spec/schemas/execution.yml b/packages/cli/src/PublicApi/v1/handlers/executions/spec/schemas/execution.yml
@@ -1,8 +1,8 @@
 type: object
 properties:
   id:
-    type: string
-    example: '1000'
+    type: number
+    example: 1000
   data:
     type: object
   finished:
@@ -12,10 +12,10 @@ properties:
     type: string
     enum: ['cli', 'error', 'integrated', 'internal', 'manual', 'retry', 'trigger', 'webhook']
   retryOf:
-    type: string
+    type: number
     nullable: true
   retrySuccessId:
-    type: string
+    type: number
     nullable: true
     example: '2'
   startedAt:
@@ -25,7 +25,7 @@ properties:
     type: string
     format: date-time
   workflowId:
-    type: string
+    type: number
     example: '1000'
   waitTill:
     type: string

diff --git a/packages/cli/src/PublicApi/v1/handlers/executions/spec/schemas/parameters/executionId.yml b/packages/cli/src/PublicApi/v1/handlers/executions/spec/schemas/parameters/executionId.yml
@@ -3,4 +3,4 @@ in: path
 description: The ID of the execution.
 required: true
 schema:
-  type: string
+  type: number
diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/parameters/workflowId.yml b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/parameters/workflowId.yml
@@ -3,4 +3,4 @@ in: path
 description: The ID of the workflow.
 required: true
 schema:
-  type: string
+  type: number
diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/tag.yml b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/tag.yml
@@ -1,8 +1,8 @@
 type: object
 properties:
   id:
-    type: string
-    example: '12'
+    type: number
+    example: 12
   name:
     type: string
     example: Production

diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflow.yml
@@ -7,9 +7,9 @@ required:
   - settings
 properties:
   id:
-    type: string
+    type: number
     readOnly: true
-    example: '1'
+    example: 1
   name:
     type: string
     example: Workflow 1

diff --git a/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflowSettings.yml b/packages/cli/src/PublicApi/v1/handlers/workflows/spec/schemas/workflowSettings.yml
@@ -16,8 +16,8 @@ properties:
     example: 3600
     maxLength: 3600
   errorWorkflow:
-    type: string
-    example: '10'
+    type: number
+    example: 10
     description: The ID of the workflow that contains the error trigger node.
   timezone:
     type: string