Merge pull request #3729 from n8n-io/fix-pin-data-enter-edit-mode

Fix pin data enter edit mode
n8n-io · Jul 18, 2022 · 7083829 · 7083829
2 parents 724f700 + 465032f
commit 7083829
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/packages/cli/test/integration/shared/types.d.ts b/packages/cli/test/integration/shared/types.d.ts
@@ -17,6 +17,7 @@ type EndpointGroup =
 	| 'owner'
 	| 'passwordReset'
 	| 'credentials'
+	| 'workflows'
 	| 'publicApi';
 
 export type CredentialPayload = {

diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue
@@ -363,6 +363,7 @@ import {
 	INodeTypeDescription,
 	IRunData,
 	IRunExecutionData,
+	PinData,
 } from 'n8n-workflow';
 
 import {
@@ -727,8 +728,9 @@ export default mixins(
 				localStorage.setItem(LOCAL_STORAGE_PIN_DATA_DISCOVERY_CANVAS_FLAG, 'true');
 			},
 			enterEditMode({ origin }: EnterEditModeArgs) {
-				const data = this.rawInputData && this.rawInputData.length > 0
-					? this.convertToJson(this.rawInputData)
+				const inputData = this.pinData ? this.pinData : this.convertToJson(this.rawInputData);
+				const data = inputData.length > 0
+					? inputData
 					: TEST_PIN_DATA;
 
 				this.$store.commit('ui/setOutputPanelEditModeEnabled', true);

diff --git a/packages/editor-ui/src/components/helpers.ts b/packages/editor-ui/src/components/helpers.ts
@@ -69,7 +69,7 @@ export function isNumber(value: unknown): value is number {
 	return typeof value === 'number';
 }
 
-export function stringSizeInBytes(input: string | IDataObject | undefined): number {
+export function stringSizeInBytes(input: string | IDataObject | IDataObject[] | undefined): number {
 	if (input === undefined) return 0;
 
 	return new Blob([typeof input === 'string' ? input : JSON.stringify(input)]).size;

diff --git a/packages/editor-ui/src/components/mixins/pinData.ts b/packages/editor-ui/src/components/mixins/pinData.ts
@@ -1,6 +1,6 @@
 import Vue from 'vue';
 import { INodeUi } from "@/Interface";
-import { IDataObject } from "n8n-workflow";
+import {IDataObject, PinData} from "n8n-workflow";
 import {stringSizeInBytes} from "@/components/helpers";
 import {MAX_WORKFLOW_PINNED_DATA_SIZE, PIN_DATA_NODE_TYPES_DENYLIST} from "@/constants";
 
@@ -11,7 +11,7 @@ interface PinDataContext {
 
 export const pinData = (Vue as Vue.VueConstructor<Vue & PinDataContext>).extend({
 	computed: {
-		pinData (): IDataObject | undefined {
+		pinData (): PinData[string] | undefined {
 			return this.node ? this.$store.getters['pinDataByNodeName'](this.node!.name) : undefined;
 		},
 		hasPinData (): boolean {