address PR comments

n8n-io · Aug 25, 2023 · 73c2167 · 73c2167
1 parent 3a6c207
commit 73c2167
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/packages/cli/src/databases/entities/AbstractEntity.ts b/packages/cli/src/databases/entities/AbstractEntity.ts
@@ -43,10 +43,7 @@ function mixinTimestamps<T extends Constructor<{}>>(base: T) {
 		@Column(tsColumnOptions)
 		createdAt: Date;
 
-		@Column({
-			...tsColumnOptions,
-			onUpdate: timestampSyntax,
-		})
+		@Column(tsColumnOptions)
 		updatedAt: Date;
 
 		@BeforeUpdate()

diff --git a/...52593-MigrateToTimestampZ1692207852593.ts → ...sdb/1692207852593-MigrateToTimestampTz.ts b/...52593-MigrateToTimestampZ1692207852593.ts → ...sdb/1692207852593-MigrateToTimestampTz.ts
@@ -20,18 +20,19 @@ const additionalColumns = {
 	workflow_statistics: ['latestEvent'],
 };
 
-export class MigrateToTimestampZ1692207852593 implements IrreversibleMigration {
+export class MigrateToTimestampTz1692207852593 implements IrreversibleMigration {
 	async up({ queryRunner, tablePrefix }: MigrationContext) {
 		const changeColumnType = async (tableName: string, columnName: string) =>
 			queryRunner.query(
-				`ALTER TABLE "${tablePrefix}${tableName}" ALTER COLUMN "${columnName}" TYPE TIMESTAMPTZ(3)`,
+				`ALTER TABLE "${tablePrefix}${tableName}" ALTER COLUMN "${columnName}" TYPE TIMESTAMP(3) WITH TIME ZONE`,
 			);
 
 		for (const tableName of tablesWithDefaultTimestamps) {
 			for (const columnName of defaultTimestampColumns) {
 				await changeColumnType(tableName, columnName);
 			}
 		}
+
 		for (const [tableName, columnNames] of Object.entries(additionalColumns)) {
 			for (const columnName of columnNames) {
 				await changeColumnType(tableName, columnName);

diff --git a/packages/cli/src/databases/migrations/postgresdb/index.ts b/packages/cli/src/databases/migrations/postgresdb/index.ts
@@ -43,7 +43,7 @@ import { RemoveResetPasswordColumns1690000000030 } from '../common/1690000000030
 import { AddMissingPrimaryKeyOnExecutionData1690787606731 } from './1690787606731-AddMissingPrimaryKeyOnExecutionData';
 import { CreateWorkflowNameIndex1691088862123 } from '../common/1691088862123-CreateWorkflowNameIndex';
 import { AddMfaColumns1690000000030 } from './../common/1690000000040-AddMfaColumns';
-import { MigrateToTimestampZ1692207852593 } from './1692207852593-MigrateToTimestampZ1692207852593';
+import { MigrateToTimestampTz1692207852593 } from './1692207852593-MigrateToTimestampTz';
 
 export const postgresMigrations: Migration[] = [
 	InitialMigration1587669153312,
@@ -90,5 +90,5 @@ export const postgresMigrations: Migration[] = [
 	AddMissingPrimaryKeyOnExecutionData1690787606731,
 	CreateWorkflowNameIndex1691088862123,
 	AddMfaColumns1690000000030,
-	MigrateToTimestampZ1692207852593,
+	MigrateToTimestampTz1692207852593,
 ];