Fix TypeScript errors workflow package

n8n-io · May 17, 2024 · 84ad6a4 · 84ad6a4
1 parent ce3eb12
commit 84ad6a4
Show file tree

Hide file tree

Showing 11 changed files with 11 additions and 17 deletions.
diff --git a/packages/editor-ui/tsconfig.json b/packages/editor-ui/tsconfig.json
@@ -11,7 +11,7 @@
 		"allowSyntheticDefaultImports": true,
 		"resolveJsonModule": true,
 		"baseUrl": ".",
-		"types": ["vitest/globals"],
+		"types": ["vitest/globals", "../workflow/src/types.d.ts"],
 		"paths": {
 			"@/*": ["src/*"],
 			"n8n-design-system/*": ["../design-system/src/*"],

diff --git a/packages/workflow/src/AugmentObject.ts b/packages/workflow/src/AugmentObject.ts
@@ -29,7 +29,7 @@ export function augmentArray<T>(data: T[]): T[] {
 	}
 
 	const proxy = new Proxy(data, {
-		deleteProperty(target, key: string) {
+		deleteProperty(_target, key: string) {
 			return Reflect.deleteProperty(getData(), key);
 		},
 		get(target, key: string, receiver): unknown {
@@ -59,7 +59,7 @@ export function augmentArray<T>(data: T[]): T[] {
 		ownKeys(target) {
 			return Reflect.ownKeys(newData ?? target);
 		},
-		set(target, key: string, newValue: unknown) {
+		set(_target, key: string, newValue: unknown) {
 			// Always proxy all objects. Like that we can check in get simply if it
 			// is a proxy and it does then not matter if it was already there from the
 			// beginning and it got proxied at some point or set later and so theoretically
@@ -143,7 +143,7 @@ export function augmentObject<T extends object>(data: T): T {
 			);
 		},
 
-		getOwnPropertyDescriptor(target, key) {
+		getOwnPropertyDescriptor(_target, key) {
 			if (deletedProperties.has(key)) return undefined;
 			return Object.getOwnPropertyDescriptor(key in newData ? newData : data, key);
 		},

diff --git a/packages/workflow/src/NativeMethods/Array.methods.ts b/packages/workflow/src/NativeMethods/Array.methods.ts
@@ -1,4 +1,4 @@
-import type { NativeDoc } from '@/Extensions/Extensions';
+import type { NativeDoc } from '../Extensions/Extensions';
 
 export const arrayMethods: NativeDoc = {
 	typeName: 'Array',

diff --git a/packages/workflow/src/NativeMethods/Boolean.methods.ts b/packages/workflow/src/NativeMethods/Boolean.methods.ts
@@ -1,4 +1,4 @@
-import type { NativeDoc } from '@/Extensions/Extensions';
+import type { NativeDoc } from '../Extensions/Extensions';
 
 export const booleanMethods: NativeDoc = {
 	typeName: 'Boolean',

diff --git a/packages/workflow/src/NativeMethods/Number.methods.ts b/packages/workflow/src/NativeMethods/Number.methods.ts
@@ -1,4 +1,4 @@
-import type { NativeDoc } from '@/Extensions/Extensions';
+import type { NativeDoc } from '../Extensions/Extensions';
 
 export const numberMethods: NativeDoc = {
 	typeName: 'Number',

diff --git a/packages/workflow/src/NativeMethods/Object.Methods.ts b/packages/workflow/src/NativeMethods/Object.Methods.ts
@@ -1,4 +1,4 @@
-import type { NativeDoc } from '@/Extensions/Extensions';
+import type { NativeDoc } from '../Extensions/Extensions';
 
 export const objectMethods: NativeDoc = {
 	typeName: 'Object',

diff --git a/packages/workflow/src/NativeMethods/String.methods.ts b/packages/workflow/src/NativeMethods/String.methods.ts
@@ -1,4 +1,4 @@
-import type { NativeDoc } from '@/Extensions/Extensions';
+import type { NativeDoc } from '../Extensions/Extensions';
 
 export const stringMethods: NativeDoc = {
 	typeName: 'String',

diff --git a/packages/workflow/src/NativeMethods/index.ts b/packages/workflow/src/NativeMethods/index.ts
@@ -2,7 +2,7 @@ import { stringMethods } from './String.methods';
 import { arrayMethods } from './Array.methods';
 import { numberMethods } from './Number.methods';
 import { objectMethods } from './Object.Methods';
-import type { NativeDoc } from '@/Extensions/Extensions';
+import type { NativeDoc } from '../Extensions/Extensions';
 import { booleanMethods } from './Boolean.methods';
 
 const NATIVE_METHODS: NativeDoc[] = [

diff --git a/packages/workflow/src/errors/credential-access-error.ts b/packages/workflow/src/errors/credential-access-error.ts
@@ -1,4 +1,4 @@
-import type { INode } from '@/Interfaces';
+import type { INode } from '../Interfaces';
 import { ExecutionBaseError } from './abstract/execution-base.error';
 
 export class CredentialAccessError extends ExecutionBaseError {

diff --git a/packages/workflow/src/errors/node-operation.error.ts b/packages/workflow/src/errors/node-operation.error.ts
@@ -6,8 +6,6 @@ import { NodeError } from './abstract/node.error';
  * Class for instantiating an operational error, e.g. an invalid credentials error.
  */
 export class NodeOperationError extends NodeError {
-	lineNumber: number | undefined;
-
 	type: string | undefined;
 
 	constructor(

diff --git a/packages/workflow/src/errors/workflow-operation.error.ts b/packages/workflow/src/errors/workflow-operation.error.ts
@@ -9,10 +9,6 @@ export class WorkflowOperationError extends ExecutionBaseError {
 
 	timestamp: number;
 
-	lineNumber: number | undefined;
-
-	description: string | undefined;
-
 	constructor(message: string, node?: INode, description?: string) {
 		super(message, { cause: undefined });
 		this.level = 'warning';