fix(editor): Make Webhook node pinnable (#9047)

n8n-io · Apr 4, 2024 · 8cbe2bf · 8cbe2bf
1 parent dbf96fc
commit 8cbe2bf
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/cypress/e2e/13-pinning.cy.ts b/cypress/e2e/13-pinning.cy.ts
@@ -69,6 +69,16 @@ describe('Data pinning', () => {
 		ndv.getters.outputTbodyCell(1, 0).should('include.text', 1);
 	});
 
+	it('should display pin data edit button for Webhook node', () => {
+		workflowPage.actions.addInitialNodeToCanvas('Webhook', { keepNdvOpen: true });
+
+		ndv.getters
+			.runDataPaneHeader()
+			.find('button')
+			.filter(':visible')
+			.should('have.attr', 'title', 'Edit Output');
+	});
+
 	it('Should be duplicating pin data when duplicating node', () => {
 		workflowPage.actions.addInitialNodeToCanvas('Schedule Trigger');
 		workflowPage.actions.addNodeToCanvas(EDIT_FIELDS_SET_NODE_NAME, true, true);

diff --git a/packages/editor-ui/src/composables/useNodeType.ts b/packages/editor-ui/src/composables/useNodeType.ts
@@ -36,7 +36,13 @@ export function useNodeType(
 			: false;
 	});
 
-	const isMultipleOutputsNodeType = computed(() => (nodeType.value?.outputs ?? []).length > 1);
+	const isMultipleOutputsNodeType = computed(() => {
+		const outputs = nodeType.value?.outputs;
+
+		if (typeof outputs === 'string') return false; // e.g. Webhook node
+
+		return (outputs ?? []).length > 1;
+	});
 
 	return {
 		nodeType,