fix(cli): initialize mailer just if connection can be verified (#3997)

n8n-io · Sep 1, 2022 · 936cb11 · 936cb11
1 parent d82e879
commit 936cb11
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/packages/cli/src/UserManagement/email/UserManagementMailer.ts b/packages/cli/src/UserManagement/email/UserManagementMailer.ts
@@ -1,6 +1,6 @@
-import Handlebars from 'handlebars';
 import { existsSync } from 'fs';
 import { readFile } from 'fs/promises';
+import Handlebars from 'handlebars';
 import { join as pathJoin } from 'path';
 // eslint-disable-next-line import/no-cycle
 import { GenericHelpers } from '../..';
@@ -90,7 +90,12 @@ let mailerInstance: UserManagementMailer | undefined;
 export async function getInstance(): Promise<UserManagementMailer> {
 	if (mailerInstance === undefined) {
 		mailerInstance = new UserManagementMailer();
-		await mailerInstance.verifyConnection();
+		try {
+			await mailerInstance.verifyConnection();
+		} catch (error) {
+			mailerInstance = undefined;
+			throw error;
+		}
 	}
 	return mailerInstance;
 }