👕 Apply node-param-options-type-unsorted-items (#3459)

* ⚡ fix * 🔨 exceptions * Add exception for Salesmate and Zoom Co-authored-by: Michael Kret <michael.k@radency.com> Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
n8n-io · Jun 3, 2022 · 978ee78 · 978ee78
1 parent b5b46ab
commit 978ee78
Show file tree

Hide file tree

Showing 121 changed files with 1,584 additions and 1,561 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -429,6 +429,7 @@ module.exports = {
 				'n8n-nodes-base/node-param-placeholder-miscased-id': 'error',
 				'n8n-nodes-base/node-param-description-miscased-url': 'error',
 				'n8n-nodes-base/node-param-option-name-wrong-for-upsert': 'error',
+				'n8n-nodes-base/node-param-options-type-unsorted-items': 'error',
 				'n8n-nodes-base/node-param-default-wrong-for-string': 'error',
 				'n8n-nodes-base/node-param-default-wrong-for-number': 'error',
 				'n8n-nodes-base/node-param-description-lowercase-first-char': 'error',

diff --git a/packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts b/packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
@@ -143,6 +143,10 @@ export class ActiveCampaign implements INodeType {
 						name: 'Account Contact',
 						value: 'accountContact',
 					},
+					{
+						name: 'Connection',
+						value: 'connection',
+					},
 					{
 						name: 'Contact',
 						value: 'contact',
@@ -155,22 +159,18 @@ export class ActiveCampaign implements INodeType {
 						name: 'Contact Tag',
 						value: 'contactTag',
 					},
-					{
-						name: 'Connection',
-						value: 'connection',
-					},
 					{
 						name: 'Deal',
 						value: 'deal',
 					},
-					{
-						name: 'E-Commerce Order',
-						value: 'ecommerceOrder',
-					},
 					{
 						name: 'E-Commerce Customer',
 						value: 'ecommerceCustomer',
 					},
+					{
+						name: 'E-Commerce Order',
+						value: 'ecommerceOrder',
+					},
 					{
 						name: 'E-Commerce Order Product',
 						value: 'ecommerceOrderProducts',

diff --git a/packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts b/packages/nodes-base/nodes/ActiveCampaign/ContactDescription.ts
@@ -405,26 +405,26 @@ export const contactFields: INodeProperties[] = [
 				name: 'status',
 				type: 'options',
 				options: [
+					{
+						name: 'Active',
+						value: 1,
+					},
 					{
 						name: 'Any',
 						value: -1,
 					},
 					{
-						name: 'Unconfirmed',
-						value: 0,
+						name: 'Bounced',
+						value: 3,
 					},
 					{
-						name: 'Active',
-						value: 1,
+						name: 'Unconfirmed',
+						value: 0,
 					},
 					{
 						name: 'Unsubscribed',
 						value: 2,
 					},
-					{
-						name: 'Bounced',
-						value: 3,
-					},
 				],
 				default: '',
 			},

diff --git a/packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts b/packages/nodes-base/nodes/ActiveCampaign/DealDescription.ts
@@ -29,6 +29,11 @@ export const dealOperations: INodeProperties[] = [
 				value: 'create',
 				description: 'Create a deal',
 			},
+			{
+				name: 'Create Note',
+				value: 'createNote',
+				description: 'Create a deal note',
+			},
 			{
 				name: 'Delete',
 				value: 'delete',
@@ -49,11 +54,6 @@ export const dealOperations: INodeProperties[] = [
 				value: 'update',
 				description: 'Update a deal',
 			},
-			{
-				name: 'Create Note',
-				value: 'createNote',
-				description: 'Create a deal note',
-			},
 			{
 				name: 'Update Deal Note',
 				value: 'updateNote',

diff --git a/packages/nodes-base/nodes/AcuityScheduling/AcuitySchedulingTrigger.node.ts b/packages/nodes-base/nodes/AcuityScheduling/AcuitySchedulingTrigger.node.ts
@@ -83,16 +83,6 @@ export class AcuitySchedulingTrigger implements INodeType {
 				required: true,
 				default: '',
 				options: [
-					{
-						name: 'appointment.scheduled',
-						value: 'appointment.scheduled',
-						description: 'Is called once when an appointment is initially booked',
-					},
-					{
-						name: 'appointment.rescheduled',
-						value: 'appointment.rescheduled',
-						description: 'Is called when the appointment is rescheduled to a new time',
-					},
 					{
 						name: 'appointment.canceled',
 						value: 'appointment.canceled',
@@ -103,6 +93,16 @@ export class AcuitySchedulingTrigger implements INodeType {
 						value: 'appointment.changed',
 						description: 'Is called when the appointment is changed in any way',
 					},
+					{
+						name: 'appointment.rescheduled',
+						value: 'appointment.rescheduled',
+						description: 'Is called when the appointment is rescheduled to a new time',
+					},
+					{
+						name: 'appointment.scheduled',
+						value: 'appointment.scheduled',
+						description: 'Is called once when an appointment is initially booked',
+					},
 					{
 						name: 'order.completed',
 						value: 'order.completed',

diff --git a/packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts b/packages/nodes-base/nodes/AgileCrm/CompanyDescription.ts
@@ -230,32 +230,32 @@ export const companyFields: INodeProperties[] = [
 						type: 'options',
 						options: [
 							{
-								name: 'Equals',
-								value: 'EQUALS',
-							},
-							{
-								name: 'Not Equal',
-								value: 'NOTEQUALS',
+								name: 'After',
+								value: 'AFTER',
 							},
 							{
-								name: 'Last',
-								value: 'LAST',
+								name: 'Before',
+								value: 'BEFORE',
 							},
 							{
 								name: 'Between',
 								value: 'BETWEEN',
 							},
 							{
-								name: 'On',
-								value: 'ON',
+								name: 'Equals',
+								value: 'EQUALS',
 							},
 							{
-								name: 'Before',
-								value: 'BEFORE',
+								name: 'Last',
+								value: 'LAST',
 							},
 							{
-								name: 'After',
-								value: 'AFTER',
+								name: 'Not Equal',
+								value: 'NOTEQUALS',
+							},
+							{
+								name: 'On',
+								value: 'ON',
 							},
 						],
 						default: 'EQUALS',

diff --git a/packages/nodes-base/nodes/AgileCrm/ContactDescription.ts b/packages/nodes-base/nodes/AgileCrm/ContactDescription.ts
@@ -230,32 +230,32 @@ export const contactFields: INodeProperties[] = [
 						type: 'options',
 						options: [
 							{
-								name: 'Equals',
-								value: 'EQUALS',
-							},
-							{
-								name: 'Not Equal',
-								value: 'NOTEQUALS',
+								name: 'After',
+								value: 'AFTER',
 							},
 							{
-								name: 'Last',
-								value: 'LAST',
+								name: 'Before',
+								value: 'BEFORE',
 							},
 							{
 								name: 'Between',
 								value: 'BETWEEN',
 							},
 							{
-								name: 'On',
-								value: 'ON',
+								name: 'Equals',
+								value: 'EQUALS',
 							},
 							{
-								name: 'Before',
-								value: 'BEFORE',
+								name: 'Last',
+								value: 'LAST',
 							},
 							{
-								name: 'After',
-								value: 'AFTER',
+								name: 'Not Equal',
+								value: 'NOTEQUALS',
+							},
+							{
+								name: 'On',
+								value: 'ON',
 							},
 						],
 						default: 'EQUALS',
@@ -645,14 +645,14 @@ export const contactFields: INodeProperties[] = [
 										name: 'Other',
 										value: 'other',
 									},
-									{
-										name: 'Work Fax',
-										value: 'workFax',
-									},
 									{
 										name: 'Work',
 										value: 'work',
 									},
+									{
+										name: 'Work Fax',
+										value: 'workFax',
+									},
 								],
 							},
 							{
@@ -1106,14 +1106,14 @@ export const contactFields: INodeProperties[] = [
 										name: 'Other',
 										value: 'other',
 									},
-									{
-										name: 'Work Fax',
-										value: 'workFax',
-									},
 									{
 										name: 'Work',
 										value: 'work',
 									},
+									{
+										name: 'Work Fax',
+										value: 'workFax',
+									},
 								],
 							},
 							{

diff --git a/packages/nodes-base/nodes/Asana/Asana.node.ts b/packages/nodes-base/nodes/Asana/Asana.node.ts
@@ -111,14 +111,14 @@ export class Asana implements INodeType {
 						name: 'Task Comment',
 						value: 'taskComment',
 					},
-					{
-						name: 'Task Tag',
-						value: 'taskTag',
-					},
 					{
 						name: 'Task Project',
 						value: 'taskProject',
 					},
+					{
+						name: 'Task Tag',
+						value: 'taskTag',
+					},
 					{
 						name: 'User',
 						value: 'user',

diff --git a/packages/nodes-base/nodes/Aws/S3/FileDescription.ts b/packages/nodes-base/nodes/Aws/S3/FileDescription.ts
@@ -287,6 +287,10 @@ export const fileFields: INodeProperties[] = [
 						name: 'Deep Archive',
 						value: 'deepArchive',
 					},
+					{
+						name: 'Glacier',
+						value: 'glacier',
+					},
 					{
 						name: 'Intelligent Tiering',
 						value: 'intelligentTiering',
@@ -295,10 +299,6 @@ export const fileFields: INodeProperties[] = [
 						name: 'One Zone IA',
 						value: 'onezoneIA',
 					},
-					{
-						name: 'Glacier',
-						value: 'glacier',
-					},
 					{
 						name: 'Standard',
 						value: 'standard',
@@ -640,6 +640,10 @@ export const fileFields: INodeProperties[] = [
 						name: 'Deep Archive',
 						value: 'deepArchive',
 					},
+					{
+						name: 'Glacier',
+						value: 'glacier',
+					},
 					{
 						name: 'Intelligent Tiering',
 						value: 'intelligentTiering',
@@ -648,10 +652,6 @@ export const fileFields: INodeProperties[] = [
 						name: 'One Zone IA',
 						value: 'onezoneIA',
 					},
-					{
-						name: 'Glacier',
-						value: 'glacier',
-					},
 					{
 						name: 'Standard',
 						value: 'standard',

diff --git a/packages/nodes-base/nodes/Aws/S3/FolderDescription.ts b/packages/nodes-base/nodes/Aws/S3/FolderDescription.ts
@@ -115,6 +115,10 @@ export const folderFields: INodeProperties[] = [
 						name: 'Deep Archive',
 						value: 'deepArchive',
 					},
+					{
+						name: 'Glacier',
+						value: 'glacier',
+					},
 					{
 						name: 'Intelligent Tiering',
 						value: 'intelligentTiering',
@@ -123,10 +127,6 @@ export const folderFields: INodeProperties[] = [
 						name: 'One Zone IA',
 						value: 'onezoneIA',
 					},
-					{
-						name: 'Glacier',
-						value: 'glacier',
-					},
 					{
 						name: 'Reduced Redundancy',
 						value: 'RecudedRedundancy',

diff --git a/packages/nodes-base/nodes/Aws/Transcribe/AwsTranscribe.node.ts b/packages/nodes-base/nodes/Aws/Transcribe/AwsTranscribe.node.ts
@@ -144,25 +144,25 @@ export class AwsTranscribe implements INodeType {
 						value: 'en-GB',
 					},
 					{
-						name: 'Irish English',
-						value: 'en-IE',
+						name: 'German',
+						value: 'de-DE',
 					},
 					{
 						name: 'Indian English',
 						value: 'en-IN',
 					},
 					{
-						name: 'Spanish',
-						value: 'es-ES',
-					},
-					{
-						name: 'German',
-						value: 'de-DE',
+						name: 'Irish English',
+						value: 'en-IE',
 					},
 					{
 						name: 'Russian',
 						value: 'ru-RU',
 					},
+					{
+						name: 'Spanish',
+						value: 'es-ES',
+					},
 				],
 				displayOptions: {
 					show: {