fix: store copy of workflow in workflowsById to prevent node data bugs (

#4637)
n8n-io · Nov 17, 2022 · 9cadaea · 9cadaea
1 parent dea67ca
commit 9cadaea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 15 deletions.
diff --git a/packages/editor-ui/src/stores/workflows.ts b/packages/editor-ui/src/stores/workflows.ts
@@ -24,6 +24,7 @@ import {
 } from "@/Interface";
 import {defineStore} from "pinia";
 import {
+	deepCopy,
 	IConnection,
 	IConnections,
 	IDataObject,
@@ -334,7 +335,10 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, {
 		},
 
 		addWorkflow(workflow: IWorkflowDb) : void {
-			Vue.set(this.workflowsById, workflow.id, workflow);
+			Vue.set(this.workflowsById, workflow.id, {
+				...this.workflowsById[workflow.id],
+				...deepCopy(workflow),
+			});
 		},
 
 		setWorkflowActive(workflowId: string): void {

diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue
@@ -834,27 +834,14 @@ export default mixins(
 					);
 				}
 
+				this.workflowsStore.addWorkflow(data);
 				this.workflowsStore.setActive(data.active || false);
 				this.workflowsStore.setWorkflowId(workflowId);
 				this.workflowsStore.setWorkflowName({ newName: data.name, setStateDirty: false });
 				this.workflowsStore.setWorkflowSettings(data.settings || {});
 				this.workflowsStore.setWorkflowPinData(data.pinData || {});
 				this.workflowsStore.setWorkflowHash(data.hash);
 
-				this.workflowsStore.addWorkflow({
-					id: data.id,
-					name: data.name,
-					ownedBy: data.ownedBy,
-					sharedWith: data.sharedWith,
-					tags: data.tags || [],
-					active: data.active,
-					createdAt: data.createdAt,
-					updatedAt: data.updatedAt,
-					nodes: data.nodes,
-					connections: data.connections,
-					hash: '',
-				});
-
 				if (data.ownedBy) {
 					this.workflowsEEStore.setWorkflowOwnedBy({
 						workflowId: data.id,