fix: Fix problem saving workflow when tags disabled (#3792)

* ⚡ Add @AfterLoad nullCheck for WorkflowEntity tags * ⚡ Make tags optional in Entity * Fix workflows api typing issue Co-authored-by: Omar Ajoue <krynble@gmail.com>
n8n-io · Aug 2, 2022 · f0dddaa · f0dddaa
1 parent 2cab8e7
commit f0dddaa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/packages/cli/src/Interfaces.ts b/packages/cli/src/Interfaces.ts
@@ -144,7 +144,7 @@ export interface IWorkflowBase extends IWorkflowBaseWorkflow {
 // Almost identical to editor-ui.Interfaces.ts
 export interface IWorkflowDb extends IWorkflowBase {
 	id: number | string;
-	tags: ITagDb[];
+	tags?: ITagDb[];
 }
 
 export interface IWorkflowToImport extends IWorkflowBase {

diff --git a/packages/cli/src/Server.ts b/packages/cli/src/Server.ts
@@ -993,7 +993,7 @@ class App {
 					);
 				}
 
-				if (updatedWorkflow.tags.length && tags?.length) {
+				if (updatedWorkflow.tags?.length && tags?.length) {
 					updatedWorkflow.tags = TagHelpers.sortByRequestOrder(updatedWorkflow.tags, {
 						requestOrder: tags,
 					});

diff --git a/packages/cli/src/api/workflows.api.ts b/packages/cli/src/api/workflows.api.ts
@@ -69,7 +69,7 @@ workflowsController.post(
 			throw new ResponseHelper.ResponseError('Failed to save workflow');
 		}
 
-		if (tagIds && !config.getEnv('workflowTagsDisabled')) {
+		if (tagIds && !config.getEnv('workflowTagsDisabled') && savedWorkflow.tags) {
 			savedWorkflow.tags = TagHelpers.sortByRequestOrder(savedWorkflow.tags, {
 				requestOrder: tagIds,
 			});

diff --git a/packages/cli/src/databases/entities/WorkflowEntity.ts b/packages/cli/src/databases/entities/WorkflowEntity.ts
@@ -112,7 +112,7 @@ export class WorkflowEntity implements IWorkflowDb {
 			referencedColumnName: 'id',
 		},
 	})
-	tags: TagEntity[];
+	tags?: TagEntity[];
 
 	@OneToMany(() => SharedWorkflow, (sharedWorkflow) => sharedWorkflow.workflow)
 	shared: SharedWorkflow[];