-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Add AI Assistant support chat #10656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comments
await assistantStore.sendMessage({ text: content, quickReplyType }); | ||
} | ||
const task = assistantStore.isSupportChatSessionInProgress ? 'support' : 'error'; | ||
const solutionCount = assistantStore.chatMessages.filter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not related to this PR. But the backend should be returning this. We discussed this in planning but dropped in handover and final implementation.
I guess it's fine since we are likely to drop this feature any way, so no need to change anything.
@@ -106,6 +110,10 @@ export const useAssistantStore = defineStore(STORES.ASSISTANT, () => { | |||
).length, | |||
); | |||
|
|||
const isSupportChatSessionInProgress = computed(() => { | |||
return currentSessionId.value !== undefined && chatSessionError.value === undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once we add credential helper, we will have to store the type. For now, this works as we only have two types.
✅ All Cypress E2E specs passed |
n8n Run #6748
Run Properties:
|
Project |
n8n
|
Branch Review |
ADO-2545-ai-assistant-support-chat
|
Run status |
Passed #6748
|
Run duration | 04m 41s |
Commit |
7cabb6fef1: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
|
Committer | Milorad Filipovic |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
424
|
View all changes introduced in this branch ↗︎ |
* master: refactor(RabbitMQ Trigger Node): Improve type-safety, add tests, and fix issues with manual triggers (#10663) feat(editor): Add support for nodes with multiple main inputs in new canvas (no-changelog) (#10659) fix(editor): Set minimum zoom to 0 to allow fitting very large workflows in new canvas (no-changelog) (#10666) feat(editor): Change selection to be default canvas behaviour (no-changelog) (#10668) feat: More hints to nodes (#10565) fix(editor): Fix opening executions tab from a new, unsaved workflow (#10652) fix(AI Agent Node): Fix tools agent when using memory and Anthropic models (#10513) feat(editor): Make highlighted data pane floating (#10638) fix(editor): Fix workflow loading after switching to executions view in new canvas (no-changelog) (#10655) refactor(benchmark): Separate cloud env provisioning from running benchmarks (#10657) feat(core): Implement wrapping of regular nodes as AI Tools (#10641) refactor(editor): Remove Trial logic in personalization modal and port to script setup (#10649) fix(core): Declutter webhook insertion errors (#10650) feat: Reintroduce collaboration feature (#10602) feat(benchmark): Add scenario for expressions with Set node (#10647) feat(benchmark): Add benchmark scenario for binary files (#10648) build: Add `reset` script (#10627) feat(editor): Overhaul node insert position computation in new canvas (no-changelog) (#10637)
✅ All Cypress E2E specs passed |
Got released with |
1 similar comment
Got released with |
Summary
This PR adds the AI Assistant support chat
Accompanying AI service PR
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-2545
Closes ADO-2550
Closes ADO-2549
Closes ADO-2546
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)