Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More hints to nodes #10565

Merged
merged 15 commits into from
Sep 4, 2024
Merged

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Aug 27, 2024

Summary

Added hints to output pane:

limit reached hint (if limit and number of returned items equal to this limit)
"Limit of [limit] items reached. There may be more items that aren't being returned. Tweak the 'Return All' or 'Limit' parameters to access more items."

Execute Once hint (on list like operations 'getAll', 'getMany', 'read', 'search' when input data length more then 1)
"The operation is performed for each input item. Use the 'Execute Once' setting to only execute it only once for the first input item."

expression in field name hint for Set node
"An expression is used in 'Fields to Set' in field [someField], did you mean to use it in the value instead?"

Split In Batches setup hints
"No nodes connected to the 'loop' output of this node"
"The last node in the branch of the 'loop' output must be connected back to the input of this node to loop correctly"

HttpRequest node (if single return item with data property containing array, after execution)
"The result has a 'data' property which contains an array of items, you can split this array into separate items by using the 'Split Out' node"

Aggregate node (if field to aggregate by not found in any input items, after execution)
"The field [field] wasn't found in any input item"

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1479/add-more-warnings-to-nodes

@michael-radency michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Aug 27, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the detailed PR description 🙌
Mostly looks good and I manually tested, all works as expected 🎉
left some minor nitpicks, also is it possible to add some tests?

packages/editor-ui/src/components/RunData.vue Outdated Show resolved Hide resolved
michael-radency and others added 6 commits September 4, 2024 12:36
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Sep 4, 2024

n8n    Run #6734

Run Properties:  status check passed Passed #6734  •  git commit ac7c953a7d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1479-add-more-warnings-to-nodes
Run status status check passed Passed #6734
Run duration 04m 53s
Commit git commit ac7c953a7d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 423
View all changes introduced in this branch ↗︎

@michael-radency michael-radency merged commit 66ddb4a into master Sep 4, 2024
32 checks passed
@michael-radency michael-radency deleted the node-1479-add-more-warnings-to-nodes branch September 4, 2024 13:33
MiloradFilipovic added a commit that referenced this pull request Sep 5, 2024
* master:
  refactor(RabbitMQ Trigger Node): Improve type-safety, add tests, and fix issues with manual triggers (#10663)
  feat(editor): Add support for nodes with multiple main inputs in new canvas (no-changelog) (#10659)
  fix(editor): Set minimum zoom to 0 to allow fitting very large workflows in new canvas (no-changelog) (#10666)
  feat(editor): Change selection to be default canvas behaviour (no-changelog) (#10668)
  feat: More hints to nodes  (#10565)
  fix(editor): Fix opening executions tab from a new, unsaved workflow (#10652)
  fix(AI Agent Node): Fix tools agent when using memory and Anthropic models (#10513)
  feat(editor): Make highlighted data pane floating (#10638)
  fix(editor): Fix workflow loading after switching to executions view in new canvas (no-changelog) (#10655)
  refactor(benchmark): Separate cloud env provisioning from running benchmarks (#10657)
  feat(core): Implement wrapping of regular nodes as AI Tools (#10641)
  refactor(editor): Remove Trial logic in personalization modal and port to script setup (#10649)
  fix(core): Declutter webhook insertion errors (#10650)
  feat: Reintroduce collaboration feature (#10602)
  feat(benchmark): Add scenario for expressions with Set node (#10647)
  feat(benchmark): Add benchmark scenario for binary files (#10648)
  build: Add `reset` script (#10627)
  feat(editor): Overhaul node insert position computation in new canvas (no-changelog) (#10637)
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

riascho pushed a commit that referenced this pull request Sep 23, 2024
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants