Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Implemented automatic position detection for credential fields. #3461

Merged
merged 4 commits into from
Jun 7, 2022
Merged

⚡ Implemented automatic position detection for credential fields. #3461

merged 4 commits into from
Jun 7, 2022

Conversation

MiloradFilipovic
Copy link
Contributor

Credentials field position is now automatically determined based on authentication fields position:

  1. Credentials show up after auth field
  2. If there are multiple credentials, they are shown after the last authentication field

@MiloradFilipovic MiloradFilipovic added core Enhancement outside /nodes-base and /editor-ui ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Jun 3, 2022
@MiloradFilipovic MiloradFilipovic requested a review from mutdmour June 3, 2022 15:21
@MiloradFilipovic MiloradFilipovic self-assigned this Jun 3, 2022
@MiloradFilipovic MiloradFilipovic mentioned this pull request Jun 3, 2022
Closed
@MiloradFilipovic
✨ Updating automatic credentials position logic (removing `getParamet…
657e100 
…erResolveOrder`call and fixing input spacing).
@MiloradFilipovic MiloradFilipovic force-pushed the N8N-3653-automatic-credentials-position branch from e086d1a to 657e100 Compare June 7, 2022 09:14
mutdmour
mutdmour approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing my endless feedback :)

@janober janober merged commit 59a59e0 into master Jun 7, 2022
@janober janober deleted the N8N-3653-automatic-credentials-position branch June 7, 2022 13:02
@janober
Copy link
Member

janober commented Jun 7, 2022

Great work. Thanks a lot. Got merged.

@janober janober added the Upcoming Release Will be part of the upcoming release label Jun 7, 2022
@janober
Copy link
Member

janober commented Jun 7, 2022

Got released with n8n@0.180.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

@alexgrozav alexgrozav Awaiting requested review from alexgrozav

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @mutdmour