Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying icons fails on second run if source directory is read-only #4973

Closed
K900 opened this issue Dec 19, 2022 · 2 comments
Closed

Copying icons fails on second run if source directory is read-only #4973

K900 opened this issue Dec 19, 2022 · 2 comments

Comments

@K900
Copy link

K900 commented Dec 19, 2022

Describe the bug
When the node_modules directory is read-only, the icon copying code will also copy the icon files as read-only, and fail to overwrite them on the next startup.

To Reproduce
Steps to reproduce the behavior:

  1. chmod -R -w node_modules
  2. Run n8n
  3. Stop n8n
  4. Run n8n

Expected behavior
n8n starts correctly.

Environment (please complete the following information):

  • OS: [e.g. Ubuntu Linux 22.04] NixOS unstable
  • n8n Version [e.g. 0.200.1] 0.208.1
  • Node.js Version [e.g. 16.17.0] 16.18.1
  • Database system [e.g. SQLite; n8n uses SQLite as default otherwise changed] SQLite
  • Operation mode [e.g. own; operation modes are own, main and queue. Default is own] own

Additional context
The NixOS packaging model requires things to be read only, so we currently can't update n8n to the versions that added the icon copying code.

@Joffcom
Copy link
Member

Joffcom commented Mar 1, 2023

Hey @K900,

It looks like this should be resolved now, I am going to mark it as closed. If you are still seeing this issue let me know and we can look into it again.

@Joffcom Joffcom closed this as completed Mar 1, 2023
@K900
Copy link
Author

K900 commented Mar 1, 2023

Thanks, it is in fact resolved, I thought the PR would auto-close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants