fix(editor): Fix save modal appearing post duplication of a workflow #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freyamade
changed the title
freyamade
changed the title
n8n-assistant
bot
added
n8n team
cstuncsik
approved these changes
Jan 25, 2023
freyamade
changed the title
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 25, 2023
* master: fix(editor): Fix save modal appearing after duplicating a workflow (#5247) feat(editor): Adjust Google sign-in button to adhere to the guidelines (#5248) fix(HelpScout Node): Fix tag search not working when getting all conversations (#5239) fix(editor): Do not request workflow data twice when opening a workflow (#5246) fix(editor): Fix the element-ui imports in SettingsLdapView (no-changelog) (#5245) fix(core): Handle missing binary metadata in download urls (#5242) ci: Simplify DB truncate in tests (no-changelog) (#5243) feat(core): Add LDAP support (#3835) fix(core): Upsert credentials and workflows in the import:* commands (#5231) feat(Jira Software Node): Use resource locator component (#5090) ci: Publish n8n docker images to GHCR (#5213) fix(Google Drive Node): Use the correct mimetype on converted downloads (#5240) fix(editor): Prevent workflow execution list infinite no network error (#5230) fix: Extension being too eager and making calls when it shouldn't (#5232) feat(Send Email Node): Overhaul refactor(core): Add support for implicit schema in postgres migrations (#5233) # Conflicts: # packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versionId in the store was being updated before any checking of "should this open in a new window" was done. This led to the versionId of the new duplicated workflow being used in the tab of the original workflow, leading to the save modal popping up erroneusly