Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Upsert credentials and workflows in the import:* commands #5231

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 23, 2023

N8N-5908

Supercedes #5192
Fixes: #2527

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 23, 2023
@netroy netroy force-pushed the N8N-5908-upsert-on-import-commands branch from 43f5b84 to 97786d9 Compare January 23, 2023 17:10
@netroy netroy force-pushed the N8N-5908-upsert-on-import-commands branch from 97786d9 to b882066 Compare January 23, 2023 17:19
@netroy netroy changed the title fix: Upsert credentials and workflows in the import:* commands fix(core): Upsert credentials and workflows in the import:* commands Jan 23, 2023
Copy link
Contributor

@that-one-tom that-one-tom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@netroy netroy merged commit 259296c into master Jan 24, 2023
@netroy netroy deleted the N8N-5908-upsert-on-import-commands branch January 24, 2023 18:05
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 24, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 25, 2023
* master:
  fix(editor): Fix save modal appearing after duplicating a workflow (#5247)
  feat(editor): Adjust Google sign-in button to adhere to the guidelines (#5248)
  fix(HelpScout Node): Fix tag search not working when getting all conversations (#5239)
  fix(editor): Do not request workflow data twice when opening a workflow (#5246)
  fix(editor): Fix the element-ui imports in SettingsLdapView (no-changelog) (#5245)
  fix(core): Handle missing binary metadata in download urls (#5242)
  ci: Simplify DB truncate in tests (no-changelog) (#5243)
  feat(core): Add LDAP support (#3835)
  fix(core): Upsert credentials and workflows in the import:* commands (#5231)
  feat(Jira Software Node): Use resource locator component (#5090)
  ci: Publish n8n docker images to GHCR (#5213)
  fix(Google Drive Node): Use the correct mimetype on converted downloads (#5240)
  fix(editor): Prevent workflow execution list infinite no network error (#5230)
  fix: Extension being too eager and making calls when it shouldn't (#5232)
  feat(Send Email Node): Overhaul
  refactor(core): Add support for implicit schema in postgres migrations (#5233)

# Conflicts:
#	packages/editor-ui/src/components/CredentialEdit/CredentialConfig.vue
@janober
Copy link
Member

janober commented Jan 27, 2023

Got released with n8n@0.213.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 27, 2023
netroy added a commit that referenced this pull request Jun 3, 2024
…ing import (no-changelog)

This code was added in #5231 before we switched workflow/credential IDs from numbers to strings in #6345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team skip-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n8n import with fixed ID
4 participants