feat(core): Fix populating of node custom api call options #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d add e2e tests to check for custom nodes credentials
OlegIvaniv
changed the title
n8n-assistant
bot
added
core
|
@netroy As you have the most context about this, can you please review it? The e2e tests should also be fixed . |
netroy
reviewed
Feb 3, 2023
netroy
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
LGTM. But, let's wait for the e2e tests to pass before we merge.
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic for injecting
customApiCallOptionsfrom thenodeTypesAPI controllerLoadNodesAndCredentialsClassafter both base and community nodes(and credentials) are loaded. It also adds three additional E2E tests to check: If the API hint is displaying accordingly, If a custom node with n8n credentials is loading correctly, and if a custom node with a custom credential is loading correctly.Since we now need to inject custom nodes in two different specs, I've moved it to a central place and made sure the correct caching headers are set.
Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/shopify-generic-api-call/22375 #5345 #5303