test: Disable resource caching when running e2e tests (no-changelog) #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIvaniv
changed the title
netroy
previously approved these changes
Feb 2, 2023
netroy
previously approved these changes
Feb 2, 2023
|
Closing this one since we've implemented better version of this fix in #5347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node-creator spec is failing because the intercept can't hook
types/nodes.jsonbecause it's being cached by the browser. This PR setscacheDisabledto true via Chromiumremote:debugger:protocoleffectively preventing the browser from caching assets.I also notice that the timeout for the
waitForLoadcommand is passed in the wrong way so I've fixed that, this should generally help with tests flakiness as it often takes more than 4s(default CY timeout) to load page in GH runner.Github issue / Community forum post (link here to close automatically):