feat(editor): Add most important native props and methods to autocomplete #5486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation. Added build-in string functions docs.
* master: fix(core): Fix data transformation function that are reported not to work properly (#5338) ci(core): Add unit tests for "me" controller (no-changelog) (#5479) fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476) fix(editor): Fix Vite dev mode (no-changelog) (#5475) feat(editor): Add correct credential owner contact details for readonly credentials (#5208) feat: Add workflow and credential sharing access e2e tests (#5463) ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473) feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
n8n-assistant
bot
added
core
mutdmour
previously approved these changes
Feb 15, 2023
| descriptionLink.setAttribute('href', fn.doc.docURL); | ||
| descriptionLink.innerText = i18n.autocompleteUIValues['docLinkLabel'] || 'Learn more'; | ||
| descriptionLink.addEventListener('mousedown', (event: MouseEvent) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
This will prevent documentation link clicks to close autocomplete dropdown before link opens.
There was a problem hiding this comment.
Can you add a comment to clarify
mutdmour
approved these changes
Feb 16, 2023
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):