Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix data transformation function that are reported not to work properly #5338

Merged
merged 171 commits into from
Feb 15, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Feb 2, 2023

This PR contains commits form @ivov's PR (#5130) which has been merged in the meantime (hence so many commits).

@MiloradFilipovic MiloradFilipovic self-assigned this Feb 2, 2023
* master: (147 commits)
  📚 Update CHANGELOG.md and main package.json to 0.215.1
  🔖 Release n8n@0.215.1
  ⬆️ Set n8n-core@0.154.1, n8n-editor-ui@0.181.1, n8n-nodes-base@0.213.1 and n8n-workflow@0.136.1 on n8n
  🔖 Release n8n-editor-ui@0.181.1
  ⬆️ Set n8n-workflow@0.136.1 on n8n-editor-ui
  🔖 Release n8n-nodes-base@0.213.1
  ⬆️ Set n8n-core@0.154.1 and n8n-workflow@0.136.1 on n8n-nodes-base
  🔖 Release n8n-node-dev@0.93.1
  ⬆️ Set n8n-core@0.154.1 and n8n-workflow@0.136.1 on n8n-node-dev
  🔖 Release n8n-core@0.154.1
  ⬆️ Set n8n-workflow@0.136.1 on n8n-core
  🔖 Release n8n-workflow@0.136.1
  fix(core): Fix issue that worker and webhook service close directly (#5461)
  fix(core): Handle versioned custom nodes correctly (#5313)
  test: Change workflows to test from safe list to skip list (#5457)
  📚 Update CHANGELOG.md and main package.json to 0.215.0
  🔖 Release n8n@0.215.0
  ⬆️ Set n8n-core@0.154.0, n8n-editor-ui@0.181.0, n8n-nodes-base@0.213.0 and n8n-workflow@0.136.0 on n8n
  🔖 Release n8n-editor-ui@0.181.0
  ⬆️ Set n8n-design-system@0.53.0 and n8n-workflow@0.136.0 on n8n-editor-ui
  ...

# Conflicts:
#	packages/workflow/package.json
#	pnpm-lock.yaml
…unit tests after removing `Object.merge` function
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job & effort👏.
I've left a few comments that I'd appreciate if you could address :)

packages/editor-ui/src/utils/typesUtils.ts Outdated Show resolved Hide resolved
packages/workflow/src/Extensions/ArrayExtensions.ts Outdated Show resolved Hide resolved
packages/workflow/src/Extensions/ArrayExtensions.ts Outdated Show resolved Hide resolved
packages/workflow/src/Extensions/ArrayExtensions.ts Outdated Show resolved Hide resolved
packages/workflow/src/Extensions/utils.ts Outdated Show resolved Hide resolved
packages/workflow/src/Extensions/ArrayExtensions.ts Outdated Show resolved Hide resolved
packages/workflow/src/Extensions/ArrayExtensions.ts Outdated Show resolved Hide resolved
* master:
  ci(core): Add unit tests for "me" controller (no-changelog) (#5479)
  fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476)
  fix(editor): Fix Vite dev mode (no-changelog) (#5475)
  feat(editor): Add correct credential owner contact details for readonly credentials (#5208)
  feat: Add workflow and credential sharing access e2e tests (#5463)
  ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473)
  feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
  docs: Update release notes link (#5472)
  test(editor): Add e2e tests for executions preview (#5458)
  📚 Update CHANGELOG.md and main package.json to 0.215.2
  🔖 Release n8n@0.215.2
  fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) (#5466)

# Conflicts:
#	pnpm-lock.yaml
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

@MiloradFilipovic MiloradFilipovic merged commit 0cf45bc into master Feb 15, 2023
@MiloradFilipovic MiloradFilipovic deleted the ado-251-data-transformation-fixes branch February 15, 2023 09:50
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 15, 2023
MiloradFilipovic added a commit that referenced this pull request Feb 15, 2023
* master:
  fix(core): Fix data transformation function that are reported not to work properly (#5338)
  ci(core): Add unit tests for "me" controller (no-changelog) (#5479)
  fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476)
  fix(editor): Fix Vite dev mode (no-changelog) (#5475)
  feat(editor): Add correct credential owner contact details for readonly credentials (#5208)
  feat: Add workflow and credential sharing access e2e tests (#5463)
  ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473)
  feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
@janober
Copy link
Member

janober commented Feb 16, 2023

Got released with n8n@0.216.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants