-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Fix data transformation function that are reported not to work properly #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (147 commits) 📚 Update CHANGELOG.md and main package.json to 0.215.1 🔖 Release n8n@0.215.1 ⬆️ Set n8n-core@0.154.1, n8n-editor-ui@0.181.1, n8n-nodes-base@0.213.1 and n8n-workflow@0.136.1 on n8n 🔖 Release n8n-editor-ui@0.181.1 ⬆️ Set n8n-workflow@0.136.1 on n8n-editor-ui 🔖 Release n8n-nodes-base@0.213.1 ⬆️ Set n8n-core@0.154.1 and n8n-workflow@0.136.1 on n8n-nodes-base 🔖 Release n8n-node-dev@0.93.1 ⬆️ Set n8n-core@0.154.1 and n8n-workflow@0.136.1 on n8n-node-dev 🔖 Release n8n-core@0.154.1 ⬆️ Set n8n-workflow@0.136.1 on n8n-core 🔖 Release n8n-workflow@0.136.1 fix(core): Fix issue that worker and webhook service close directly (#5461) fix(core): Handle versioned custom nodes correctly (#5313) test: Change workflows to test from safe list to skip list (#5457) 📚 Update CHANGELOG.md and main package.json to 0.215.0 🔖 Release n8n@0.215.0 ⬆️ Set n8n-core@0.154.0, n8n-editor-ui@0.181.0, n8n-nodes-base@0.213.0 and n8n-workflow@0.136.0 on n8n 🔖 Release n8n-editor-ui@0.181.0 ⬆️ Set n8n-design-system@0.53.0 and n8n-workflow@0.136.0 on n8n-editor-ui ... # Conflicts: # packages/workflow/package.json # pnpm-lock.yaml
…unit tests after removing `Object.merge` function
OlegIvaniv
requested changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job & effort👏.
I've left a few comments that I'd appreciate if you could address :)
* master: ci(core): Add unit tests for "me" controller (no-changelog) (#5479) fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476) fix(editor): Fix Vite dev mode (no-changelog) (#5475) feat(editor): Add correct credential owner contact details for readonly credentials (#5208) feat: Add workflow and credential sharing access e2e tests (#5463) ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473) feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454) docs: Update release notes link (#5472) test(editor): Add e2e tests for executions preview (#5458) 📚 Update CHANGELOG.md and main package.json to 0.215.2 🔖 Release n8n@0.215.2 fix(core): Fix the issue with test webhooks getting removed incorrectly (no-changelog) (#5466) # Conflicts: # pnpm-lock.yaml
OlegIvaniv
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👌
n8n-assistant
bot
added
the
Upcoming Release
Will be part of the upcoming release
label
Feb 15, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Feb 15, 2023
* master: fix(core): Fix data transformation function that are reported not to work properly (#5338) ci(core): Add unit tests for "me" controller (no-changelog) (#5479) fix(core): Use stricter typing on queries in cli commands (no-changelog) (#5476) fix(editor): Fix Vite dev mode (no-changelog) (#5475) feat(editor): Add correct credential owner contact details for readonly credentials (#5208) feat: Add workflow and credential sharing access e2e tests (#5463) ci: Update the "Check Documentation URLs" workflow (no-changelog) (#5473) feat(editor): Upgrade to Storybook v7 (no-changelog) (#5454)
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits form @ivov's PR (#5130) which has been merged in the meantime (hence so many commits).