Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Add ssh key type selection to source control settings when regenerating key #7172

Merged
merged 3 commits into from
Sep 14, 2023
Merged

fix(editor): Add ssh key type selection to source control settings when regenerating key #7172

merged 3 commits into from
Sep 14, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 92.50% and project coverage change: +0.02% 🎉

Comparison is base (fdac2c8) 32.42% compared to head (fde00b2) 32.44%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7172      +/-   ##
==========================================
+ Coverage   32.42%   32.44%   +0.02%     
==========================================
  Files        3279     3279              
  Lines      198043   198092      +49     
  Branches    21653    21662       +9     
==========================================
+ Hits        64209    64274      +65     
+ Misses     132774   132758      -16     
  Partials     1060     1060
Files Changed Coverage Δ
packages/editor-ui/src/utils/typeHelpers.ts 0.00% <0.00%> (ø)
...ages/editor-ui/src/views/SettingsSourceControl.vue 92.29% <90.69%> (+3.65%) ⬆️
...ckages/editor-ui/src/stores/sourceControl.store.ts 75.38% <90.90%> (+4.39%) ⬆️
packages/editor-ui/src/Interface.ts 100.00% <100.00%> (ø)
packages/editor-ui/src/api/sourceControl.ts 74.39% <100.00%> (+5.05%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #2174 ↗︎

0 241 0 0 Flakiness 0

Details:

🌳 pay-815-add-toggle-for-ssh-key-type-generation-to-frontend 🖥️ browsers:node1...
Project: n8n Commit: fde00b209e
Status: Passed Duration: 08:45 💡
Started: Sep 14, 2023 12:29 PM Ended: Sep 14, 2023 12:38 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit 54bf66d into master Sep 14, 2023
@cstuncsik cstuncsik deleted the pay-815-add-toggle-for-ssh-key-type-generation-to-frontend branch September 14, 2023 12:40
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Merged
krynble added a commit that referenced this pull request Sep 20, 2023
@github-actions @krynble
🚀 Release 1.8.0 (#7219)
ecd5d93 
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0)
(2023-09-20)


### Bug Fixes

* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217](#7217))
([d41546b](d41546b)),
closes [#7149](#7149)
* **core:** Resolve domains to IPv4 first
([#7206](#7206))
([e9ce531](e9ce531))
* **editor:** Add ssh key type selection to source control settings when
regenerating key ([#7172](#7172))
([54bf66d](54bf66d))
* **editor:** No need to add click emitting click events, VUE delegates
the handler to the root element of the component
([#7182](#7182))
([3c055e4](3c055e4))
* **editor:** Prevent duplicate creation of credential for OAuth2
([#7163](#7163))
([07a6417](07a6417))
* **editor:** Testing flaky resource mapper feature in e2e tests
([#7165](#7165))
([aaf87c3](aaf87c3))
* **HTML Node:** Add pairedItem support for 'Convert to HTML Table'
operation ([#7196](#7196))
([6bc477b](6bc477b))
* **HTTP Request Node:** Decrease default timeout to 5min
([#7177](#7177))
([321780d](321780d))
* **seven Node:** Rename sms77 to seven, fix credentials test
([#7180](#7180))
([cf776b8](cf776b8))
* **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter
alias) ([#7179](#7179))
([d317e09](d317e09))


### Features

* **core:** Add command to trigger license refresh on workers
([#7184](#7184))
([9f797b9](9f797b9))
* **core:** Add rsa option to ssh key generation
([#7154](#7154))
([fdac2c8](fdac2c8))
* **Linear Node:** Add support for OAuth2
([#7201](#7201))
([12a3168](12a3168))
* **Microsoft Outlook Node:** Node overhaul
([#4449](#4449))
([556a613](556a613))
* **Set Node:** Overhaul
([#6348](#6348))
([3a47455](3a47455))

Co-authored-by: krynble <krynble@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flipswitchingmonkey flipswitchingmonkey flipswitchingmonkey approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @flipswitchingmonkey