fix(editor): Prevent duplicate creation of credential for OAuth2 #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7163 +/- ##
==========================================
- Coverage 32.40% 32.40% -0.01%
==========================================
Files 3276 3276
Lines 198005 198004 -1
Branches 21652 21653 +1
==========================================
- Hits 64162 64157 -5
- Misses 132782 132786 +4
Partials 1061 1061
☔ View full report in Codecov by Sentry. |
krynble
approved these changes
Sep 13, 2023
Passing run #2159 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
krynble
changed the title
krynble
changed the title
krynble
deleted the
pay-825-click-to-connect-for-google-sheets-does-not-work-when-cred
branch
netroy
pushed a commit
that referenced
this pull request
Sep 14, 2023
This PR solves the issue reported in [this ticket](https://linear.app/n8n/issue/PAY-825/click-to-connect-for-google-sheets-does-not-work-when-cred-is-not). Basically when trying to connect OAuth2 credentials, n8n would create the credential twice, possibly causing transaction issues. This PR prevents n8n from firing a duplicate creation request, effectively fixing the bug about duplicate creation.
Merged
netroy
added a commit
that referenced
this pull request
Sep 14, 2023
## [1.7.1](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.7.1) (2023-09-14) ### Bug Fixes * **editor:** Prevent duplicate creation of credential for OAuth2 ([#7163](#7163)) ([f6d7ffe](f6d7ffe)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Merged
krynble
added a commit
that referenced
this pull request
Sep 20, 2023
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0) (2023-09-20) ### Bug Fixes * **core:** Make parsing of content-type and content-disposition headers more flexible ([#7217](#7217)) ([d41546b](d41546b)), closes [#7149](#7149) * **core:** Resolve domains to IPv4 first ([#7206](#7206)) ([e9ce531](e9ce531)) * **editor:** Add ssh key type selection to source control settings when regenerating key ([#7172](#7172)) ([54bf66d](54bf66d)) * **editor:** No need to add click emitting click events, VUE delegates the handler to the root element of the component ([#7182](#7182)) ([3c055e4](3c055e4)) * **editor:** Prevent duplicate creation of credential for OAuth2 ([#7163](#7163)) ([07a6417](07a6417)) * **editor:** Testing flaky resource mapper feature in e2e tests ([#7165](#7165)) ([aaf87c3](aaf87c3)) * **HTML Node:** Add pairedItem support for 'Convert to HTML Table' operation ([#7196](#7196)) ([6bc477b](6bc477b)) * **HTTP Request Node:** Decrease default timeout to 5min ([#7177](#7177)) ([321780d](321780d)) * **seven Node:** Rename sms77 to seven, fix credentials test ([#7180](#7180)) ([cf776b8](cf776b8)) * **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter alias) ([#7179](#7179)) ([d317e09](d317e09)) ### Features * **core:** Add command to trigger license refresh on workers ([#7184](#7184)) ([9f797b9](9f797b9)) * **core:** Add rsa option to ssh key generation ([#7154](#7154)) ([fdac2c8](fdac2c8)) * **Linear Node:** Add support for OAuth2 ([#7201](#7201)) ([12a3168](12a3168)) * **Microsoft Outlook Node:** Node overhaul ([#4449](#4449)) ([556a613](556a613)) * **Set Node:** Overhaul ([#6348](#6348)) ([3a47455](3a47455)) Co-authored-by: krynble <krynble@users.noreply.github.com>
easydigi
pushed a commit
to easydigi/n8n
that referenced
this pull request
Sep 22, 2023
(2023-09-14) * **editor:** Prevent duplicate creation of credential for OAuth2 ([n8n-io#7163](n8n-io#7163)) ([f6d7ffe](n8n-io@f6d7ffe)) Co-authored-by: netroy <netroy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue reported in this ticket.
Basically when trying to connect OAuth2 credentials, n8n would create the credential twice, possibly causing transaction issues.
This PR prevents n8n from firing a duplicate creation request, effectively fixing the bug about duplicate creation.