Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Node): Decrease default timeout to 5min #7177

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 14, 2023

Github issue / Community forum post (link here to close automatically):

fixes #7081

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@elsmr elsmr changed the title Decrease default HTTP Request node timeout to 5min fix(HTTP Request Node): Decrease default timeout to 5min Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (9f797b9) 32.65% compared to head (782e3a7) 32.65%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7177      +/-   ##
==========================================
- Coverage   32.65%   32.65%   -0.01%     
==========================================
  Files        3340     3340              
  Lines      199463   199463              
  Branches    21845    21847       +2     
==========================================
- Hits        65132    65130       -2     
- Misses     133251   133253       +2     
  Partials     1080     1080              
Files Changed Coverage Δ
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts 33.33% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 14, 2023
@elsmr elsmr requested a review from Joffcom September 15, 2023 12:55
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Sep 15, 2023

Passing run #2207 ↗︎

0 238 3 0 Flakiness 0

Details:

🌳 node-746-http-timeout-decrease 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃...
Project: n8n Commit: 782e3a72ae
Status: Passed Duration: 07:35 💡
Started: Sep 19, 2023 8:42 AM Ended: Sep 19, 2023 8:49 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit 321780d into master Sep 20, 2023
18 checks passed
@elsmr elsmr deleted the node-746-http-timeout-decrease branch September 20, 2023 10:38
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
krynble added a commit that referenced this pull request Sep 20, 2023
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0)
(2023-09-20)


### Bug Fixes

* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217](#7217))
([d41546b](d41546b)),
closes [#7149](#7149)
* **core:** Resolve domains to IPv4 first
([#7206](#7206))
([e9ce531](e9ce531))
* **editor:** Add ssh key type selection to source control settings when
regenerating key ([#7172](#7172))
([54bf66d](54bf66d))
* **editor:** No need to add click emitting click events, VUE delegates
the handler to the root element of the component
([#7182](#7182))
([3c055e4](3c055e4))
* **editor:** Prevent duplicate creation of credential for OAuth2
([#7163](#7163))
([07a6417](07a6417))
* **editor:** Testing flaky resource mapper feature in e2e tests
([#7165](#7165))
([aaf87c3](aaf87c3))
* **HTML Node:** Add pairedItem support for 'Convert to HTML Table'
operation ([#7196](#7196))
([6bc477b](6bc477b))
* **HTTP Request Node:** Decrease default timeout to 5min
([#7177](#7177))
([321780d](321780d))
* **seven Node:** Rename sms77 to seven, fix credentials test
([#7180](#7180))
([cf776b8](cf776b8))
* **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter
alias) ([#7179](#7179))
([d317e09](d317e09))


### Features

* **core:** Add command to trigger license refresh on workers
([#7184](#7184))
([9f797b9](9f797b9))
* **core:** Add rsa option to ssh key generation
([#7154](#7154))
([fdac2c8](fdac2c8))
* **Linear Node:** Add support for OAuth2
([#7201](#7201))
([12a3168](12a3168))
* **Microsoft Outlook Node:** Node overhaul
([#4449](#4449))
([556a613](556a613))
* **Set Node:** Overhaul
([#6348](#6348))
([3a47455](3a47455))

Co-authored-by: krynble <krynble@users.noreply.github.com>
MiloradFilipovic added a commit that referenced this pull request Sep 20, 2023
* master:
  refactor(core): Implement soft-deletions for executions (#7092)
  docs(Google Sheets Node): Operations naming update (no-changelog) (#7211)
  fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217)
  fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196)
  fix(HTTP Request Node): Decrease default timeout to 5min (#7177)
  feat(Linear Node): Add support for OAuth2 (#7201)
  refactor: Ignore large-scale revisions (no-changelog) (#7210)
  fix(core): Resolve domains to IPv4 first (#7206)
  ci: Fix tests failing on MySQL (no-changelog) (#7208)
  feat(Set Node): Overhaul (#6348)
  fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP requests should have a default timeout to prevent memory leaks
3 participants