Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Resolve domains to IPv4 first #7206

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(core): Resolve domains to IPv4 first #7206

merged 1 commit into from
Sep 19, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 19, 2023

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

Joffcom
Joffcom approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@Joffcom Joffcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see this breaking anything

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 62.53% and project coverage change: +0.03% 🎉

Comparison is base (050ba70) 32.65% compared to head (f88634d) 32.69%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7206      +/-   ##
==========================================
+ Coverage   32.65%   32.69%   +0.03%     
==========================================
  Files        3340     3346       +6     
  Lines      199463   199750     +287     
  Branches    21849    21891      +42     
==========================================
+ Hits        65139    65300     +161     
- Misses     133244   133355     +111     
- Partials     1080     1095      +15
Files Changed Coverage Δ
packages/cli/src/WorkflowRunnerProcess.ts 0.00% <0.00%> (ø)
...es/editor-ui/src/components/ParameterInputList.vue 54.66% <0.00%> (-0.31%) ⬇️
...des/Code/descriptions/JavascriptCodeDescription.ts 100.00% <ø> (ø)
...e/nodes/Code/descriptions/PythonCodeDescription.ts 100.00% <ø> (ø)
packages/nodes-base/nodes/CrateDb/CrateDb.node.ts 0.00% <ø> (ø)
...uery/v2/actions/database/executeQuery.operation.ts 41.89% <ø> (ø)
...odes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/MySql/v1/MySqlV1.node.ts 0.00% <ø> (ø)
...es/nodes-base/nodes/Postgres/v1/PostgresV1.node.ts 0.00% <ø> (ø)
...ges/nodes-base/nodes/Postgres/v2/actions/router.ts 0.00% <0.00%> (ø)
... and 20 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 19, 2023

1 flaky test on run #2213 ↗︎

0 234 3 0 Flakiness 1

Details:

🌳 HELP-326-resolve-ipv4-first 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ ...
Project: n8n Commit: f88634d7e7
Status: Passed Duration: 08:34 💡
Started: Sep 19, 2023 11:50 AM Ended: Sep 19, 2023 11:58 AM
Flakiness  cypress/e2e/24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Sep 19, 2023
@luizeof
Copy link
Contributor

luizeof commented Sep 19, 2023

This will solve a lot of problems we face with some VPS providers, thank you very much.

@netroy netroy merged commit e9ce531 into master Sep 19, 2023
18 checks passed
@netroy netroy deleted the HELP-326-resolve-ipv4-first branch September 19, 2023 13:56
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Merged
krynble added a commit that referenced this pull request Sep 20, 2023
@github-actions @krynble
🚀 Release 1.8.0 (#7219)
ecd5d93 
# [1.8.0](https://github.com/n8n-io/n8n/compare/n8n@1.7.0...n8n@1.8.0)
(2023-09-20)


### Bug Fixes

* **core:** Make parsing of content-type and content-disposition headers
more flexible ([#7217](#7217))
([d41546b](d41546b)),
closes [#7149](#7149)
* **core:** Resolve domains to IPv4 first
([#7206](#7206))
([e9ce531](e9ce531))
* **editor:** Add ssh key type selection to source control settings when
regenerating key ([#7172](#7172))
([54bf66d](54bf66d))
* **editor:** No need to add click emitting click events, VUE delegates
the handler to the root element of the component
([#7182](#7182))
([3c055e4](3c055e4))
* **editor:** Prevent duplicate creation of credential for OAuth2
([#7163](#7163))
([07a6417](07a6417))
* **editor:** Testing flaky resource mapper feature in e2e tests
([#7165](#7165))
([aaf87c3](aaf87c3))
* **HTML Node:** Add pairedItem support for 'Convert to HTML Table'
operation ([#7196](#7196))
([6bc477b](6bc477b))
* **HTTP Request Node:** Decrease default timeout to 5min
([#7177](#7177))
([321780d](321780d))
* **seven Node:** Rename sms77 to seven, fix credentials test
([#7180](#7180))
([cf776b8](cf776b8))
* **X (Formerly Twitter) Node:** Rename Twitter to X (keep Twitter
alias) ([#7179](#7179))
([d317e09](d317e09))


### Features

* **core:** Add command to trigger license refresh on workers
([#7184](#7184))
([9f797b9](9f797b9))
* **core:** Add rsa option to ssh key generation
([#7154](#7154))
([fdac2c8](fdac2c8))
* **Linear Node:** Add support for OAuth2
([#7201](#7201))
([12a3168](12a3168))
* **Microsoft Outlook Node:** Node overhaul
([#4449](#4449))
([556a613](556a613))
* **Set Node:** Overhaul
([#6348](#6348))
([3a47455](3a47455))

Co-authored-by: krynble <krynble@users.noreply.github.com>
MiloradFilipovic added a commit that referenced this pull request Sep 20, 2023
@MiloradFilipovic
Merge branch 'master' into ado-1061-banners-rework
319864e 
* master:
  refactor(core): Implement soft-deletions for executions (#7092)
  docs(Google Sheets Node): Operations naming update (no-changelog) (#7211)
  fix(core): Make parsing of content-type and content-disposition headers more flexible (#7217)
  fix(HTML Node): Add pairedItem support for 'Convert to HTML Table' operation (#7196)
  fix(HTTP Request Node): Decrease default timeout to 5min (#7177)
  feat(Linear Node): Add support for OAuth2 (#7201)
  refactor: Ignore large-scale revisions (no-changelog) (#7210)
  fix(core): Resolve domains to IPv4 first (#7206)
  ci: Fix tests failing on MySQL (no-changelog) (#7208)
  feat(Set Node): Overhaul (#6348)
  fix: Attempt license renewal when n8n starts (no-changelog) (#7204)
@DerEnderKeks
Copy link
Contributor

Please revert this change. It disgusts me to see something like this being implemented. RFC 8305 exists for a reason.
People should fix their IPv6 setups and software should never be bent backwards to use legacy IPv4 over IPv6. If a domain has v6 records, they should always be preferred. Things like this are the reason why IPv6 isn't as dominantly used by now as it should be. If you keep it like this, you are part of the problem.

If you really feel like having this anti-feature, it should be an optional config option and certainly not a forced default.

@janober
Copy link
Member

janober commented Sep 21, 2023

Got released with n8n@1.8.1

@MeesJ
Copy link

MeesJ commented Sep 27, 2023

If you really feel like having this anti-feature, it should be an optional config option and certainly not a forced default.

This! You should make this a configuration so that end users can determine themselves whether they want to prioritize IPv4 over IPv6 or not. I was really excited to see that n8n finally started prioritizing IPv6 after the release of 1.0, and it's very disappointing to see that you're reverting this change so quickly. Please reconsider this!

@netroy
Copy link
Member Author

netroy commented Sep 27, 2023 •
edited
Loading

It disgusts me to see something like this being implemented

@DerEnderKeks When communicating with other people, language matters. Please read our code of conduct and adhere to it, to avoid getting blocked.
In general, be kind to other, and give others a chance to fix an issue before starting with the outrage.

@netroy
Copy link
Member Author

netroy commented Sep 27, 2023

@MeesJ sorry for the inconvenience. This will be fixed in #7272, and should hopefully go out in today's release.

@DerEnderKeks
Copy link
Contributor

@netroy While my remark may have been inappropriate, it wasn't personal. Either way, I'm sorry, and thanks for making it configurable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@netroy @luizeof @DerEnderKeks @janober @MeesJ @Joffcom