feat: HighLevel oauth2 api credentials #9542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
reviewed
May 29, 2024
| @@ -25,7 +25,12 @@ export class OAuth2CredentialController extends AbstractOAuthController { | |||
| // At some point in the past we saved hidden scopes to credentials (but shouldn't) | |||
| // Delete scope before applying defaults to make sure new scopes are present on reconnect | |||
| // Generic Oauth2 API is an exception because it needs to save the scope | |||
| const genericOAuth2 = ['oAuth2Api', 'googleOAuth2Api', 'microsoftOAuth2Api']; | |||
| const genericOAuth2 = [ | |||
There was a problem hiding this comment.
why is this change necessary? is it to prevent the delete decryptedDataOriginal.scope call?
There was a problem hiding this comment.
We have bug with Scopes property in OAuth2 as it not possible to set value there, scopes are always empty in authorization url, I will create ticket for that
There was a problem hiding this comment.
in that case we should leave a comment in the code linking to the ticket, to make sure that anyone looking at this code isn't confused about why one particular service's oauth credential type is being included in the generic type list.
…enterprise-request-support-for-highlevel-api-v2
…enterprise-request-support-for-highlevel-api-v2
elsmr
changed the title
elsmr
approved these changes
May 30, 2024
|
|
Passing run #5184 ↗︎
Details:
Review all test suite changes for PR #9542 ↗︎ |
|||||||||||||||
…enterprise-request-support-for-highlevel-api-v2
elsmr
approved these changes
May 30, 2024
|
✅ All Cypress E2E specs passed |
elsmr
deleted the
node-783-enterprise-request-support-for-highlevel-api-v2
branch
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
May 31, 2024
* master: fix(editor): Fix ts errors across the board (no-changelog) (#9561) refactor(core): Extract all Auth-related User columns into a separate entity (#9557) refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527) fix(editor): Render checkboxes in markdown (#9549) test(core): Rename and combine all credential api tests (no-changelog) (#9550) 🚀 Release 1.44.0 (#9553) feat(editor): Node Creator AI nodes improvements (#9484) fix(editor): Show workflow data in header when execution page is hard reloaded (#9529) refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552) feat: HighLevel oauth2 api credentials (#9542) fix(editor): Fix empty node name handling (#9548) ci: Fix vulnerable dev dependencies (no-changelog) (#9545) fix: Don't throw errors for NaN in number operators in the filter component (#9506) fix(core): Try setting postgres search_path on the database (#9530) fix(editor): Redirect to workflows list after deleting a workflow (#9546) # Conflicts: # packages/editor-ui/src/views/NodeView.vue # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
support for HighLevel API v2 credentials
Review / Merge checklist
https://linear.app/n8n/issue/NODE-783/enterprise-request-support-for-highlevel-api-v2