Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Set postgres search_path to the desired schema on every connection #9530

Merged
merged 1 commit into from
May 30, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented May 28, 2024

Typeorm PR n8n-io/typeorm#13

Related tickets and issues

https://community.n8n.io/t/update-fails-1-43-0/47066/13

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 28, 2024
@netroy netroy force-pushed the fix-postgres-schema branch from 9c58a29 to 912c1cd Compare May 29, 2024 16:01
@netroy netroy requested a review from despairblue May 29, 2024 16:01
despairblue
despairblue previously approved these changes May 29, 2024
Copy link
Contributor

@despairblue despairblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works.

Copy link

cypress bot commented May 29, 2024

1 flaky test on run #5177 ↗︎

0 359 0 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 2fe37598e0
Status: Passed Duration: 04:51 💡
Started: May 30, 2024 10:04 AM Ended: May 30, 2024 10:09 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9530 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit e55bf03 into master May 30, 2024
28 checks passed
@netroy netroy deleted the fix-postgres-schema branch May 30, 2024 10:09
@github-actions github-actions bot mentioned this pull request May 30, 2024
@janober
Copy link
Member

janober commented May 30, 2024

Got released with n8n@1.44.0

@netroy netroy changed the title fix(core): Try setting postgres search_path on the database fix(core): Set postgres search_path to the desired schema on every connection May 30, 2024
MiloradFilipovic added a commit that referenced this pull request May 31, 2024
* master:
  fix(editor): Fix ts errors across the board (no-changelog) (#9561)
  refactor(core): Extract all Auth-related User columns into a separate entity (#9557)
  refactor(core): Update supertest, and fix some typing errors (no-changelog) (#9527)
  fix(editor): Render checkboxes in markdown (#9549)
  test(core): Rename and combine all credential api tests (no-changelog) (#9550)
  🚀 Release 1.44.0 (#9553)
  feat(editor): Node Creator AI nodes improvements  (#9484)
  fix(editor): Show workflow data in header when execution page is hard reloaded (#9529)
  refactor(core): Stop reporting to Sentry `NodeApiError` with 5xx status codes (no-changelog) (#9552)
  feat: HighLevel oauth2 api credentials (#9542)
  fix(editor): Fix empty node name handling (#9548)
  ci: Fix vulnerable dev dependencies (no-changelog) (#9545)
  fix: Don't throw errors for NaN in number operators in the filter component  (#9506)
  fix(core): Try setting postgres search_path on the database (#9530)
  fix(editor): Redirect to workflows list after deleting a workflow (#9546)

# Conflicts:
#	packages/editor-ui/src/views/NodeView.vue
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants