Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add notice to S3 node to mention AWS S3 node (no-changelog) #10034

Merged

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jul 12, 2024

Summary

Adds a notice to the S3 node to let users know it isn't intended for AWS S3

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1398/help-users-distinguish-aws-s3-and-s3-nodes

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Jul 12, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Jul 12, 2024

3 flaky tests on run #5912 ↗︎

0 400 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project: n8n Commit: a450a9716f
Status: Passed Duration: 05:43 💡
Started: Jul 12, 2024 1:13 PM Ended: Jul 12, 2024 1:19 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #10034 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit f3833a7 into master Jul 12, 2024
27 checks passed
@Joffcom Joffcom deleted the node-1398-help-users-distinguish-aws-s3-and-s3-nodes branch July 12, 2024 15:41
@janober
Copy link
Member

janober commented Jul 17, 2024

Got released with n8n@1.51.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants