Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loop node no input data shown #10224

Conversation

michael-radency
Copy link
Contributor

Summary

fix for:
Schema view: no input data shown for first node after a loop node
You can't switch to table/JSON view either.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1533/schema-view-no-input-data-shown-for-first-node-after-a-loop-node

…schema-view-no-input-data-shown-for-first-node-after-a-loop
@michael-radency michael-radency added ui Enhancement in /editor-ui or /design-system n8n team Authored by the n8n team labels Jul 29, 2024
ShireenMissi
ShireenMissi previously approved these changes Jul 29, 2024
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jul 29, 2024



Test summary

390 0 0 0Flakiness 0


Run details

Project n8n
Status Passed
Commit 3bffd16
Started Jul 31, 2024 12:57 PM
Ended Jul 31, 2024 1:02 PM
Duration 04:46 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Linear, this fix shouldn't be merged for now.

@ShireenMissi ShireenMissi dismissed their stale review July 30, 2024 09:51

As discussed on Linear, this fix shouldn't be merged for now.

…schema-view-no-input-data-shown-for-first-node-after-a-loop
…schema-view-no-input-data-shown-for-first-node-after-a-loop
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit c8ee852 into master Jul 31, 2024
27 checks passed
@michael-radency michael-radency deleted the node-1533-schema-view-no-input-data-shown-for-first-node-after-a-loop branch July 31, 2024 13:11
MiloradFilipovic added a commit that referenced this pull request Jul 31, 2024
* master:
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  🚀 Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
MiloradFilipovic added a commit that referenced this pull request Aug 1, 2024
* master:
  refactor(core): Decouple workflow created, saved, deleted events from internal hooks (no-changelog) (#10264)
  fix(core): Fix oauth2 callback and add integration tests (no-changelog) (#10272)
  fix(n8n Form Trigger Node): Improve copy and a few tweaks (no-changelog) (#10243)
  fix(core): Fix expressions in webhook nodes(Form, Webhook) to access previous node's data (#10247)
  refactor(core): Port endpoints config (no-changelog) (#10268)
  feat(AWS Lambda Node): Add support for paired items (no-changelog) (#10270)
  fix: Loop node no input data shown (#10224)
  fix(core): Make OAuth1/OAuth2 callback not require auth (#10263)
  🚀 Release 1.53.0 (#10266)
  fix(core): Upgrade @n8n/vm2 to address CVE‑2023‑37466 (#10265)
  feat(Calendly Trigger Node): Add OAuth Credentials Support (#10251)
  test(core): Improve and expand log streaming tests (no-changelog) (#10261)
  refactor(editor): Migrate `WorkflowExecutionsListView.vue` to composition API (no-changelog) (#10198)
  fix(core): Restore log event `n8n.workflow.failed` (#10253)
  test(core): Stop showing JWT warning during test runs (no-changelog) (#10255)
  fix(Postgres Node): Expressions in query parameters for Postgres executeQuery operation (#10217)
  fix(editor): Fix workflow execution list scrolling after filter change (#10226)
@despairblue despairblue added the release/backport Changes that need to be backported to older releases. label Aug 2, 2024
despairblue pushed a commit that referenced this pull request Aug 2, 2024
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
@janober
Copy link
Member

janober commented Aug 2, 2024

Got released with n8n@1.53.1

@github-actions github-actions bot mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants