fix(editor): Enable moving resources only if team projects are available by the license #10271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble by the license
cstuncsik
added
the
release/backport
n8n-assistant
bot
added
n8n team
tomi
previously approved these changes
Aug 1, 2024
| @@ -49,19 +49,19 @@ export const useProjectsStore = defineStore('projects', () => { | |||
| ); | |||
| const teamProjects = computed(() => projects.value.filter((p) => p.type === ProjectTypes.Team)); | |||
| const teamProjectsLimit = computed(() => settingsStore.settings.enterprise.projects.team.limit); | |||
| const teamProjectsAvailable = computed<boolean>( | |||
| const isTeamProjectsAvailable = computed<boolean>( | |||
There was a problem hiding this comment.
👍 much better with the prefix. Tho to be grammatically correct, we should name this areTeamProjectsAvailable, as it's plural projects
There was a problem hiding this comment.
Yes, probably. I was considering it as the feature name, and actually, with that in mind, it should be isTeamProjectFeatureEnabled
|
✅ All Cypress E2E specs passed |
|
Test summaryRun details
Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||||||||||
|
✅ All Cypress E2E specs passed |
cstuncsik
deleted the
pay-1798-bug-cannot-rely-on-planname-to-check-for-permission-to-move
branch
despairblue
pushed a commit
that referenced
this pull request
Aug 2, 2024
…ble by the license (#10271)
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 2, 2024
* master: refactor(core): Clean up event relays (no-changelog) (#10284) fix(editor): Fix execution retry button (#10275) feat(core): Show sub-node error on the logs pane. Open logs pane on sub-node error (#10248) refactor(core): Move instanceRole to InstanceSettings (no-changelog) (#10242) feat(core): Allow filtering executions and users by project in Public API (#10250) fix(core): Make execution and its data creation atomic (#10276) refactor(core): Mark schema env vars used by cloud hooks (no-changelog) (#10283) ci: Fix DB tests (no-changelog) (#10282) feat(core): Support create, delete, edit role for users in Public API (#10279) refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) (#10280) feat(core): Allow transferring credentials in Public API (#10259) feat(core): Support create, read, update, delete projects in Public API (#10269) ci: Introduce lint rule `no-type-unsafe-event-emitter` (no-changelog) (#10254) fix(core): Surface enterprise trial error message (#10267) fix(editor): Enable moving resources only if team projects are available by the license (#10271) fix(core): Upgrade tournament to address some XSS vulnerabilities (#10277) # Conflicts: # packages/cli/src/Server.ts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current setting of the Move action is broken. We can't rely on the plan name because it is the same on the cloud, where we should enable moving resources even when the plan name shows
Communityif the users have a quota for team projects.Related Linear tickets, Github issues, and Community forum posts
PAY-1798
Review / Merge checklist
release/backport