test(core): Move unit tests closer to testable components (no-changelog) #10287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
commented
Aug 2, 2024
| @@ -25,6 +24,36 @@ import { ProjectRepository } from '@/databases/repositories/project.repository'; | |||
|
|
|||
| const ownershipService = mockInstance(OwnershipService); | |||
|
|
|||
| function mockNodeTypesData( | |||
There was a problem hiding this comment.
Moved from test/unit/Helpers.ts
| * the macrotask queue and so called at the next iteration of the event loop | ||
| * after all promises in the microtask queue have settled first. | ||
| */ | ||
| export const flushPromises = async () => await new Promise(setImmediate); |
There was a problem hiding this comment.
Moved from test/unit/Helpers.ts
Unit tests have been residing in `test/unit/` directory. We want to them to be closer to the source files. This moves all the unit tests to `__tests__` directories next to the components that are being tested.
tomi
force-pushed
the
test-move-cli-unit-tests-closer-to-test-target-files
branch
from
c926395 to
b4d89c8
Compare
n8n-assistant
bot
added
core
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 5, 2024
* master: feat(editor): Auto-add LLM chain for new LLM nodes on empty canvas (#10245) fix(core): Fix user telemetry bugs (#10293) refactor(core): Remove stray log from telemetry event relay (no-changelog) (#10295) refactor(core): Decouple user events from internal hooks (no-changelog) (#10292) feat(core): Support community packages in scaling-mode (#10228) test(core): Move unit tests closer to testable components (no-changelog) (#10287) fix(core): Webhook and form baseUrl missing (#10290) refactor(core): Port cache config (no-changelog) (#10286)
ivov
added a commit
that referenced
this pull request
Aug 6, 2024
Import paths were different at 1.45 and have seen changes e.g. with #10287
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unit tests have been residing in
test/unit/directory. We want to them to be closer to the source files. This moves all the unit tests to__tests__directories next to the components that are being tested.Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)