-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Automate more of the release process (no-changelog) #10416
Conversation
4a86c66
to
fd32a89
Compare
merge-back-into-master: | ||
name: Merge back into master | ||
needs: [publish-to-npm, create-github-release] | ||
if: ${{ github.event.pull_request.merged == true && !contains(github.event.pull_request.labels.*.name, 'release:patch') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there also label release:major
? Should those be merged back as well? The PR description says:
and if the release was labeled with release:minor, the newly created tab is automatically merged back into master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this will work for release:major
as well. I just didn't want to document that bit yet, until we have first finalized the updated release process for major releases.
@@ -22,11 +22,6 @@ on: | |||
required: false | |||
default: 'browsers:node18.12.0-chrome107' | |||
type: string | |||
cache-key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not being used, and also can not be used because cypress containers use a completely different working directory, so the cache never restores, because actions/cache
uses absolute paths for both save
as well as `restore.
I'd like to update this setup to allow using a cache, so that we can stop building the app on every CI job, but that would be quite a lot more work that does not belong on this PR.
merge-back-into-master: | ||
name: Merge back into master | ||
needs: [publish-to-npm, create-github-release] | ||
if: ${{ github.event.pull_request.merged == true && !contains(github.event.pull_request.labels.*.name, 'release:patch') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this will work for release:major
as well. I just didn't want to document that bit yet, until we have first finalized the updated release process for major releases.
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
Got released with |
Summary
This PR updates the release process to automate more parts.
release:minor
orrelease:patch
.release:minor
, the newly created tab is automatically merged back intomaster
.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ENG-112
https://linear.app/n8n/issue/ENG-113
https://linear.app/n8n/issue/ENG-115
https://linear.app/n8n/issue/ENG-120
Review / Merge checklist