feat(editor): Overhaul handle rendering to allow dragging of plus button (no-changelog) #10512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
…ing-a-plus-connector-of-a-node-we-should-open-the
elsmr
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Nice!
I've noticed the position of the added node is messed up when you click the plus button:
Did some investigation and found the click handler is not firing. Instead it's probably using the mousedown handler of the Vue Flow Handle component, could be part of the problem.
elsmr
previously approved these changes
Aug 23, 2024
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
n8n-7565-when-dragging-a-plus-connector-of-a-node-we-should-open-the
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | Alex Grozav |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
414
|
| View all changes introduced in this branch ↗︎ | |
elsmr
approved these changes
Aug 26, 2024
|
✅ All Cypress E2E specs passed |
alexgrozav
deleted the
n8n-7565-when-dragging-a-plus-connector-of-a-node-we-should-open-the
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 26, 2024
* master: refactor(core): Standardize filename casing for environments and eventbus (no-changelog) (#10527) fix(editor): Fix node positions update event in new canvas (no-changelog) (#10528) feat(editor): Set default canvas version to version 2 on internal deployment (no-changelog) (#10514) feat(editor): Overhaul handle rendering to allow dragging of plus button (no-changelog) (#10512)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2024-08-22.at.14.49.44.mov
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/N8N-7565/when-dragging-a-plus-connector-of-a-node-we-should-open-the-nodes
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)