Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Enforce filename casing in cli package (no-changelog) #10594

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 28, 2024

Follow-up to #10579

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 28, 2024
packages/cli/.eslintrc.js Outdated Show resolved Hide resolved
@ivov ivov marked this pull request as ready for review August 28, 2024 15:38
@ivov ivov requested a review from a team as a code owner August 28, 2024 15:38
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 🙏🏽

Copy link

cypress bot commented Aug 28, 2024

n8n    Run #6654

Run Properties:  status check passed Passed #6654  •  git commit 554f677d1f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review enforce-filename-casing-in-cli
Run status status check passed Passed #6654
Run duration 04m 39s
Commit git commit 554f677d1f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 421
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 6485ca0 into master Aug 28, 2024
37 checks passed
@ivov ivov deleted the enforce-filename-casing-in-cli branch August 28, 2024 15:57
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants