Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix forceConsistentCasingInFileNames for aliased paths (no-changelog) #10598

Merged
merged 1 commit into from
Aug 29, 2024
Merged

ci: Fix forceConsistentCasingInFileNames for aliased paths (no-changelog) #10598

merged 1 commit into from
Aug 29, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Aug 29, 2024

forceConsistentCasingInFileNames is failing the build on macOS due to mixed casing in interfaces.ts and Interfaces.ts in imports in cli and workflow. The imports however are consistent - always lowercase interfaces.ts in cli and always capitalized Interfaces.ts in workflow and no cross-package imports of interfaces.

forceConsistentCasingInFileNames is (mis?)reporting only imports containing aliased paths, so this PR removes the alias for the three relevant imports until we can fully standardize casing across all BE packages.

Ref: https://n8nio.slack.com/archives/C03MZF137FV/p1724910596524169

TS error 
src/workflows/workflows.controller.ts:8:40 - error TS1149: File name '/Users/ivov/Development/n8n/packages/cli/src/interfaces.ts' differs from already included file name '/Users/ivov/Development/n8n/packages/cli/src/Interfaces.ts' only in casing.
The file is in the program because:
  Imported via '@/Interfaces' from file '/Users/ivov/Development/n8n/packages/workflow/dist/errors/workflow-operation.error.d.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/active-workflow-manager.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/workflow-helpers.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/utils/generators.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/entities/credentials-entity.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/entities/user.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/entities/workflow-entity.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/requests.ts'
  Imported via './interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/license.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/redis/redis-service-commands.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/events/relay-event-map.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/active-executions.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/repositories/execution.repository.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/concurrency/concurrency-control.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/posthog/index.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/telemetry/index.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-hooks.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/workflow-runner.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/push/index.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/push/abstract.push.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/credentials-helper.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/credentials-overwrites.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/workflow-execute-additional-data.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/tag.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/migrations/mysqldb/1681134145996-AddUserActivatedProperty.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/migrations/postgresdb/1681134145996-AddUserActivatedProperty.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/databases/migrations/sqlite/1681134145996-AddUserActivatedProperty.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/credentials/credentials.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/user.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/external-secrets-manager.ee.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/external-secrets-providers.ee.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/infisical.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/vault.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/vault.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/aws-secrets/types.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/aws-secrets/aws-secrets-manager.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/azure-key-vault/azure-key-vault.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/azure-key-vault/types.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/gcp-secrets-manager/gcp-secrets-manager.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/providers/gcp-secrets-manager/types.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/execution-lifecycle-hooks/shared/shared-hook-functions.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/workflows/workflow.request.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/workflows/workflow-execution.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/errors/workflow-missing-id.error.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/webhooks/test-webhook-registrations.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/webhooks/test-webhooks.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/eventbus/event-message-classes/event-message-workflow.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/executions/execution-recovery.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/webhooks/webhook-helpers.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/executions/execution.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/wait-tracker.ts'
  Imported via '@/Interfaces' from file '/Users/ivov/Development/n8n/packages/workflow/dist/errors/abstract/node.error.d.ts'
  Imported via '@/Interfaces' from file '/Users/ivov/Development/n8n/packages/workflow/dist/errors/node-operation.error.d.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/abstract-server.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/waiting-forms.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/webhooks/waiting-webhooks.ts'
  Matched by include pattern 'src/**/*.ts' in 'tsconfig.build.json'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/decorators/controller.registry.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/decorators/types.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/decorators/licensed.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/server.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/community-packages.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/auth.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/me.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/oauth/abstract-oauth.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/users.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/workflow-statistics.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/executions/execution.service.ee.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/external-secrets/external-secrets.service.ee.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/workflows/workflows.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/community-packages.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/controllers/e2e.controller.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/environments/source-control/source-control-import.service.ee.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/base-command.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/events/telemetry-event-relay.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/execute-batch.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/execute.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/start.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/worker.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/export/credentials.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/commands/import/workflow.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/import.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/public-api/v1/shared/middlewares/global.middleware.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/public-api/v1/handlers/credentials/credentials.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/hooks.service.ts'
  Imported via '@/interfaces' from file '/Users/ivov/Development/n8n/packages/cli/src/services/orchestration/pubsub/pubsub-message-map.ts'

8 import type { IWorkflowResponse } from '@/interfaces';

../workflow/dist/errors/workflow-operation.error.d.ts:1:28
  1 import type { INode } from '@/Interfaces';
                               ~~~~~~~~~~~~~~
  File is included via import here.
src/active-workflow-manager.ts:29:34
  29 import type { IWorkflowDb } from '@/interfaces';
                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/workflow-helpers.ts:16:52
  16 import type { IWorkflowExecutionDataProcess } from '@/interfaces';
                                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/utils/generators.ts:3:38
  3 import type { N8nInstanceType } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/entities/credentials-entity.ts:5:37
  5 import type { ICredentialsDb } from '@/interfaces';
                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/entities/user.ts:19:52
  19 import type { IPersonalizationSurveyAnswers } from '@/interfaces';
                                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/entities/workflow-entity.ts:14:34
  14 import type { IWorkflowDb } from '@/interfaces';
                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/requests.ts:18:72
  18 import type { PublicUser, SecretsProvider, SecretsProviderState } from '@/interfaces';
                                                                            ~~~~~~~~~~~~~~
  File is included via import here.
src/license.ts:15:84
  15 import type { BooleanLicenseFeature, N8nInstanceType, NumericLicenseFeature } from './interfaces';
                                                                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/services/redis/redis-service-commands.ts:1:79
  1 import type { IPushDataType, IPushDataWorkerStatusPayload, IWorkflowDb } from '@/interfaces';
                                                                                  ~~~~~~~~~~~~~~
  File is included via import here.
src/events/relay-event-map.ts:7:65
  7 import type { IWorkflowDb, IWorkflowExecutionDataProcess } from '@/interfaces';
                                                                    ~~~~~~~~~~~~~~
  File is included via import here.
src/active-executions.ts:23:8
  23 } from '@/interfaces';
            ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/repositories/execution.repository.ts:38:8
  38 } from '@/interfaces';
            ~~~~~~~~~~~~~~
  File is included via import here.
src/concurrency/concurrency-control.service.ts:9:45
  9 import type { IExecutingWorkflowData } from '@/interfaces';
                                                ~~~~~~~~~~~~~~
  File is included via import here.
src/posthog/index.ts:6:33
  6 import type { PublicUser } from '@/interfaces';
                                    ~~~~~~~~~~~~~~
  File is included via import here.
src/telemetry/index.ts:9:48
  9 import type { IExecutionTrackProperties } from '@/interfaces';
                                                   ~~~~~~~~~~~~~~
  File is included via import here.
src/external-hooks.ts:3:70
  3 import type { IExternalHooksFileData, IExternalHooksFunctions } from '@/interfaces';
                                                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/workflow-runner.ts:29:72
  29 import type { IExecutionResponse, IWorkflowExecutionDataProcess } from '@/interfaces';
                                                                            ~~~~~~~~~~~~~~
  File is included via import here.
src/push/index.ts:13:36
  13 import type { IPushDataType } from '@/interfaces';
                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/push/abstract.push.ts:2:36
  2 import type { IPushDataType } from '@/interfaces';
                                       ~~~~~~~~~~~~~~
  File is included via import here.
src/credentials-helper.ts:30:37
  30 import type { ICredentialsDb } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/credentials-overwrites.ts:5:44
  5 import type { ICredentialsOverwrite } from '@/interfaces';
                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/workflow-execute-additional-data.ts:49:8
  49 } from '@/interfaces';
            ~~~~~~~~~~~~~~
  File is included via import here.
src/services/tag.service.ts:4:38
  4 import type { ITagWithCountDb } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/migrations/mysqldb/1681134145996-AddUserActivatedProperty.ts:2:35
  2 import type { UserSettings } from '@/interfaces';
                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/migrations/postgresdb/1681134145996-AddUserActivatedProperty.ts:2:35
  2 import type { UserSettings } from '@/interfaces';
                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/databases/migrations/sqlite/1681134145996-AddUserActivatedProperty.ts:2:35
  2 import type { UserSettings } from '@/interfaces';
                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/credentials/credentials.service.ts:18:37
  18 import type { ICredentialsDb } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/services/user.service.ts:7:45
  7 import type { Invitation, PublicUser } from '@/interfaces';
                                                ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/external-secrets-manager.ee.ts:6:8
  6 } from '@/interfaces';
           ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/external-secrets-providers.ee.ts:1:38
  1 import type { SecretsProvider } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/infisical.ts:1:85
  1 import type { SecretsProvider, SecretsProviderSettings, SecretsProviderState } from '@/interfaces';
                                                                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/vault.ts:1:68
  1 import type { SecretsProviderSettings, SecretsProviderState } from '@/interfaces';
                                                                       ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/vault.ts:2:33
  2 import { SecretsProvider } from '@/interfaces';
                                    ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/aws-secrets/types.ts:1:46
  1 import type { SecretsProviderSettings } from '@/interfaces';
                                                 ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/aws-secrets/aws-secrets-manager.ts:4:60
  4 import type { SecretsProvider, SecretsProviderState } from '@/interfaces';
                                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/azure-key-vault/azure-key-vault.ts:3:60
  3 import type { SecretsProvider, SecretsProviderState } from '@/interfaces';
                                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/azure-key-vault/types.ts:1:46
  1 import type { SecretsProviderSettings } from '@/interfaces';
                                                 ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/gcp-secrets-manager/gcp-secrets-manager.ts:3:60
  3 import type { SecretsProvider, SecretsProviderState } from '@/interfaces';
                                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/providers/gcp-secrets-manager/types.ts:1:46
  1 import type { SecretsProviderSettings } from '@/interfaces';
                                                 ~~~~~~~~~~~~~~
  File is included via import here.
src/execution-lifecycle-hooks/shared/shared-hook-functions.ts:3:53
  3 import type { ExecutionPayload, IExecutionDb } from '@/interfaces';
                                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/workflows/workflow.request.ts:1:34
  1 import type { IWorkflowDb } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/workflows/workflow-execution.service.ts:29:8
  29 } from '@/interfaces';
            ~~~~~~~~~~~~~~
  File is included via import here.
src/errors/workflow-missing-id.error.ts:1:34
  1 import type { IWorkflowDb } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/webhooks/test-webhook-registrations.service.ts:4:34
  4 import type { IWorkflowDb } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/webhooks/test-webhooks.ts:29:34
  29 import type { IWorkflowDb } from '@/interfaces';
                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/eventbus/event-message-classes/event-message-workflow.ts:6:37
  6 import type { IExecutionBase } from '@/interfaces';
                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/executions/execution-recovery.service.ts:10:41
  10 import type { IExecutionResponse } from '@/interfaces';
                                             ~~~~~~~~~~~~~~
  File is included via import here.
src/webhooks/webhook-helpers.ts:56:79
  56 import type { IExecutionDb, IWorkflowDb, IWorkflowExecutionDataProcess } from '@/interfaces';
                                                                                   ~~~~~~~~~~~~~~
  File is included via import here.
src/executions/execution.service.ts:25:8
  25 } from '@/interfaces';
            ~~~~~~~~~~~~~~
  File is included via import here.
src/wait-tracker.ts:3:52
  3 import type { IWorkflowExecutionDataProcess } from '@/interfaces';
                                                       ~~~~~~~~~~~~~~
  File is included via import here.
../workflow/dist/errors/abstract/node.error.d.ts:1:40
  1 import type { INode, JsonObject } from '@/Interfaces';
                                           ~~~~~~~~~~~~~~
  File is included via import here.
../workflow/dist/errors/node-operation.error.d.ts:1:40
  1 import type { INode, JsonObject } from '@/Interfaces';
                                           ~~~~~~~~~~~~~~
  File is included via import here.
src/abstract-server.ts:12:33
  12 import { N8nInstanceType } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/waiting-forms.ts:3:41
  3 import type { IExecutionResponse } from '@/interfaces';
                                            ~~~~~~~~~~~~~~
  File is included via import here.
src/webhooks/waiting-webhooks.ts:17:54
  17 import type { IExecutionResponse, IWorkflowDb } from '@/interfaces';
                                                          ~~~~~~~~~~~~~~
  File is included via import here.
tsconfig.build.json:8:14
  8  "include": ["src/**/*.ts"],
                 ~~~~~~~~~~~~~
  File is matched by include pattern specified here.
src/decorators/controller.registry.ts:9:44
  9 import type { BooleanLicenseFeature } from '@/interfaces';
                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/decorators/types.ts:3:44
  3 import type { BooleanLicenseFeature } from '@/interfaces';
                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/decorators/licensed.ts:1:44
  1 import type { BooleanLicenseFeature } from '@/interfaces';
                                               ~~~~~~~~~~~~~~
  File is included via import here.
src/server.ts:26:44
  26 import type { ICredentialsOverwrite } from '@/interfaces';
                                                ~~~~~~~~~~~~~~
  File is included via import here.
src/services/community-packages.service.ts:25:40
  25 import type { CommunityPackages } from '@/interfaces';
                                            ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/auth.controller.ts:9:33
  9 import type { PublicUser } from '@/interfaces';
                                    ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/me.controller.ts:17:33
  17 import type { PublicUser } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/oauth/abstract-oauth.controller.ts:11:37
  11 import type { ICredentialsDb } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/users.controller.ts:12:33
  12 import type { PublicUser } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/workflow-statistics.controller.ts:7:52
  7 import type { IWorkflowStatisticsDataLoaded } from '@/interfaces';
                                                       ~~~~~~~~~~~~~~
  File is included via import here.
src/executions/execution.service.ee.ts:3:68
  3 import type { IExecutionResponse, IExecutionFlattedResponse } from '@/interfaces';
                                                                       ~~~~~~~~~~~~~~
  File is included via import here.
src/external-secrets/external-secrets.service.ee.ts:2:38
  2 import type { SecretsProvider } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/community-packages.controller.ts:9:40
  9 import type { CommunityPackages } from '@/interfaces';
                                           ~~~~~~~~~~~~~~
  File is included via import here.
src/controllers/e2e.controller.ts:12:82
  12 import type { BooleanLicenseFeature, IPushDataType, NumericLicenseFeature } from '@/interfaces';
                                                                                      ~~~~~~~~~~~~~~
  File is included via import here.
src/environments/source-control/source-control-import.service.ee.ts:14:40
  14 import type { IWorkflowToImport } from '@/interfaces';
                                            ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/base-command.ts:17:38
  17 import type { N8nInstanceType } from '@/interfaces';
                                          ~~~~~~~~~~~~~~
  File is included via import here.
src/events/telemetry-event-relay.ts:17:48
  17 import type { IExecutionTrackProperties } from '@/interfaces';
                                                    ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/execute-batch.ts:14:65
  14 import type { IWorkflowDb, IWorkflowExecutionDataProcess } from '@/interfaces';
                                                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/execute.ts:8:52
  8 import type { IWorkflowExecutionDataProcess } from '@/interfaces';
                                                       ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/start.ts:29:52
  29 import type { IWorkflowExecutionDataProcess } from '@/interfaces';
                                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/worker.ts:12:44
  12 import type { ICredentialsOverwrite } from '@/interfaces';
                                                ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/export/credentials.ts:5:62
  5 import type { ICredentialsDb, ICredentialsDecryptedDb } from '@/interfaces';
                                                                 ~~~~~~~~~~~~~~
  File is included via import here.
src/commands/import/workflow.ts:12:40
  12 import type { IWorkflowToImport } from '@/interfaces';
                                            ~~~~~~~~~~~~~~
  File is included via import here.
src/services/import.service.ts:15:37
  15 import type { ICredentialsDb } from '@/interfaces';
                                         ~~~~~~~~~~~~~~
  File is included via import here.
src/public-api/v1/shared/middlewares/global.middleware.ts:12:44
  12 import type { BooleanLicenseFeature } from '@/interfaces';
                                                ~~~~~~~~~~~~~~
  File is included via import here.
src/public-api/v1/handlers/credentials/credentials.service.ts:9:37
  9 import type { ICredentialsDb } from '@/interfaces';
                                        ~~~~~~~~~~~~~~
  File is included via import here.
src/services/hooks.service.ts:20:33
  20 import type { Invitation } from '@/interfaces';
                                     ~~~~~~~~~~~~~~
  File is included via import here.
src/services/orchestration/pubsub/pubsub-message-map.ts:1:49
  1 import type { IPushDataType, IWorkflowDb } from '@/interfaces';
                                                    ~~~~~~~~~~~~~~
  File is included via import here.


Found 82 errors in 81 files.

Errors  Files
   1  src/abstract-server.ts:12
   1  src/active-executions.ts:23
   1  src/active-workflow-manager.ts:29
   1  src/commands/base-command.ts:17
   1  src/commands/execute-batch.ts:14
   1  src/commands/execute.ts:8
   1  src/commands/export/credentials.ts:5
   1  src/commands/import/workflow.ts:12
   1  src/commands/start.ts:29
   1  src/commands/worker.ts:12
   1  src/concurrency/concurrency-control.service.ts:9
   1  src/controllers/auth.controller.ts:9
   1  src/controllers/community-packages.controller.ts:9
   1  src/controllers/e2e.controller.ts:12
   1  src/controllers/me.controller.ts:17
   1  src/controllers/oauth/abstract-oauth.controller.ts:11
   1  src/controllers/users.controller.ts:12
   1  src/controllers/workflow-statistics.controller.ts:7
   1  src/credentials-helper.ts:30
   1  src/credentials-overwrites.ts:5
   1  src/credentials/credentials.service.ts:18
   1  src/databases/entities/credentials-entity.ts:5
   1  src/databases/entities/user.ts:19
   1  src/databases/entities/workflow-entity.ts:14
   1  src/databases/migrations/mysqldb/1681134145996-AddUserActivatedProperty.ts:2
   1  src/databases/migrations/postgresdb/1681134145996-AddUserActivatedProperty.ts:2
   1  src/databases/migrations/sqlite/1681134145996-AddUserActivatedProperty.ts:2
   1  src/databases/repositories/execution.repository.ts:38
   1  src/databases/utils/generators.ts:3
   1  src/decorators/controller.registry.ts:9
   1  src/decorators/licensed.ts:1
   1  src/decorators/types.ts:3
   1  src/environments/source-control/source-control-import.service.ee.ts:14
   1  src/errors/workflow-missing-id.error.ts:1
   1  src/eventbus/event-message-classes/event-message-workflow.ts:6
   1  src/events/relay-event-map.ts:7
   1  src/events/telemetry-event-relay.ts:17
   1  src/execution-lifecycle-hooks/shared/shared-hook-functions.ts:3
   1  src/executions/execution-recovery.service.ts:10
   1  src/executions/execution.service.ee.ts:3
   1  src/executions/execution.service.ts:25
   1  src/external-hooks.ts:3
   1  src/external-secrets/external-secrets-manager.ee.ts:6
   1  src/external-secrets/external-secrets-providers.ee.ts:1
   1  src/external-secrets/external-secrets.service.ee.ts:2
   1  src/external-secrets/providers/aws-secrets/aws-secrets-manager.ts:4
   1  src/external-secrets/providers/aws-secrets/types.ts:1
   1  src/external-secrets/providers/azure-key-vault/azure-key-vault.ts:3
   1  src/external-secrets/providers/azure-key-vault/types.ts:1
   1  src/external-secrets/providers/gcp-secrets-manager/gcp-secrets-manager.ts:3
   1  src/external-secrets/providers/gcp-secrets-manager/types.ts:1
   1  src/external-secrets/providers/infisical.ts:1
   2  src/external-secrets/providers/vault.ts:1
   1  src/license.ts:15
   1  src/posthog/index.ts:6
   1  src/public-api/v1/handlers/credentials/credentials.service.ts:9
   1  src/public-api/v1/shared/middlewares/global.middleware.ts:12
   1  src/push/abstract.push.ts:2
   1  src/push/index.ts:13
   1  src/requests.ts:18
   1  src/server.ts:26
   1  src/services/community-packages.service.ts:25
   1  src/services/hooks.service.ts:20
   1  src/services/import.service.ts:15
   1  src/services/orchestration/pubsub/pubsub-message-map.ts:1
   1  src/services/redis/redis-service-commands.ts:1
   1  src/services/tag.service.ts:4
   1  src/services/user.service.ts:7
   1  src/telemetry/index.ts:9
   1  src/wait-tracker.ts:3
   1  src/waiting-forms.ts:3
   1  src/webhooks/test-webhook-registrations.service.ts:4
   1  src/webhooks/test-webhooks.ts:29
   1  src/webhooks/waiting-webhooks.ts:17
   1  src/webhooks/webhook-helpers.ts:56
   1  src/workflow-execute-additional-data.ts:49
   1  src/workflow-helpers.ts:16
   1  src/workflow-runner.ts:29
   1  src/workflows/workflow-execution.service.ts:29
   1  src/workflows/workflow.request.ts:1
   1  src/workflows/workflows.controller.ts:8

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Aug 29, 2024
alexgrozav
alexgrozav approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Aug 29, 2024 •
edited
Loading

n8n    Run #6658

Run Properties:  status check passed Passed #6658  •  git commit 713404619f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review fix-forceConsistentCasingInFileNames
Run status status check passed Passed #6658
Run duration 04m 50s
Commit git commit 713404619f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 421
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@ivov ivov merged commit 821ca16 into master Aug 29, 2024
32 checks passed
@ivov ivov deleted the fix-forceConsistentCasingInFileNames branch August 29, 2024 08:40
MiloradFilipovic added a commit that referenced this pull request Aug 30, 2024
@MiloradFilipovic
Merge branch 'master' into ai-assistant-improvements
0c53737 
* master: (21 commits)
  feat: Add queue mode setup to benchmarks (no-changelog) (#10608)
  feat: Add n8n postgres setup to benchmarks (no-changelog) (#10604)
  fix(API): Update express-openapi-validator to resolve AIKIDO-2024-10229 (#10612)
  fix: Fix edge case in log in (no-changelog) (#10610)
  feat: Add local orchestration of benchmarks (no-changelog) (#10589)
  ci: Run nightly benchmark against nightly n8n image (no-changelog) (#10588)
  fix: Reduce variability in benchmarks (no-changelog) (#10606)
  docs: Add missing changelog entry (#10609)
  refactor(editor): Convert ResourceLocator to composition API (no-changelog) (#10526)
  feat(editor): Update new canvas node handle label rendering mechanism and design (no-changelog) (#10611)
  refactor(editor): Convert credential related components to composition API (no-changelog) (#10530)
  fix(HTTP Request Node): Sanitize authorization headers (#10607)
  refactor: Use `NodeConnectionType` consistently across the code base (no-changelog) (#10595)
  fix(editor): Hide execution buttons in readonly mode in new canvas (no-changelog) (#10603)
  fix(editor): Prevent keyboard shortcuts when ndv is open in new canvas (no-changelog) (#10601)
  fix(editor): Add confirmation toast when changing user role (#10592)
  feat(editor): Add support for changing sticky notes color in new canvas (no-changelog) (#10593)
  ci: Fix `forceConsistentCasingInFileNames` for aliased paths (no-changelog) (#10598)
  feat(editor): Allow sticky notes alongside fallback nodes in new canvas (no-changelog) (#10583)
  ci: Push nightly images to ghcr (no-changelog) (#10580)
  ...
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @alexgrozav