Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Allow disabling SSO when config request fails #10635

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Sep 2, 2024

Summary

Allow disabling SSO even when the request to fetch the configuration /rest/sso/saml/config fails

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-1812/bug-if-saml-config-breaks-the-ui-wont-allow-you-to-disable-it

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@r00gm r00gm changed the title Pay 1812 bug if saml config breaks the UI wont allow you to disable fix(editor): Allow disabling SSO when config request fails Sep 2, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 2, 2024
@r00gm r00gm marked this pull request as ready for review September 2, 2024 12:27
@r00gm r00gm requested a review from cstuncsik September 2, 2024 12:27
Copy link

cypress bot commented Sep 2, 2024

n8n    Run #6704

Run Properties:  status check passed Passed #6704  •  git commit 709f03b165: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-1812-bug-if-saml-config-breaks-the-ui-wont-allow-you-to-disable
Run status status check passed Passed #6704
Run duration 04m 41s
Commit git commit 709f03b165: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer r00gm
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 422
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Sep 2, 2024

✅ All Cypress E2E specs passed

@r00gm r00gm merged commit ce39933 into master Sep 3, 2024
49 of 54 checks passed
@r00gm r00gm deleted the pay-1812-bug-if-saml-config-breaks-the-ui-wont-allow-you-to-disable branch September 3, 2024 08:06
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants