Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text Classifier Node): Add output fixing parser #10667

Merged

Conversation

burivuhster
Copy link
Contributor

@burivuhster burivuhster commented Sep 4, 2024

Summary

This PR adds an option to enable auto-fixing model's output using OutputFixingParser. The auto-fixing is enabled by default.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/AI-281/text-classifier-unexpected-non-whitespace-character

n8n-io/n8n-docs#2451

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@burivuhster burivuhster changed the title feat(Text Classifier Node): add fixing parser feat(Text Classifier Node): Add output fixing parser Sep 4, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Sep 4, 2024
@burivuhster burivuhster marked this pull request as ready for review September 4, 2024 14:07
Copy link
Contributor

@jeanpaul jeanpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good, but one quick comment about the description; we might need a bit more explanation that this will call the LLM again when the output is broken.

@burivuhster burivuhster requested a review from jeanpaul September 5, 2024 07:20
Copy link
Contributor

@jeanpaul jeanpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link

cypress bot commented Sep 5, 2024

n8n    Run #6746

Run Properties:  status check passed Passed #6746  •  git commit 4e5f2a0bec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-281-text-classifier-unexpected-non-whitespace-character
Run status status check passed Passed #6746
Run duration 04m 40s
Commit git commit 4e5f2a0bec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 422
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit aa37c32 into master Sep 5, 2024
32 checks passed
@burivuhster burivuhster deleted the ai-281-text-classifier-unexpected-non-whitespace-character branch September 5, 2024 07:39
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@janober
Copy link
Member

janober commented Sep 5, 2024

Got released with n8n@1.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants