-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Text Classifier Node): Add output fixing parser #10667
feat(Text Classifier Node): Add output fixing parser #10667
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, but one quick comment about the description; we might need a bit more explanation that this will call the LLM again when the output is broken.
packages/@n8n/nodes-langchain/nodes/chains/TextClassifier/TextClassifier.node.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
n8n Run #6746
Run Properties:
|
Project |
n8n
|
Branch Review |
ai-281-text-classifier-unexpected-non-whitespace-character
|
Run status |
Passed #6746
|
Run duration | 04m 40s |
Commit |
4e5f2a0bec: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
|
Committer | Eugene Molodkin |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
422
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Got released with |
Summary
This PR adds an option to enable auto-fixing model's output using
OutputFixingParser
. The auto-fixing is enabled by default.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-281/text-classifier-unexpected-non-whitespace-character
n8n-io/n8n-docs#2451
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)