Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Read/Write Files from Disk Node): Escape parenthesis when reading file #11753

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Nov 15, 2024

Summary

allows to read files with filenames such as test(1).txt

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2010/community-issue-readwrite-files-from-disk-node-fails-to-return-data-if
fixes #11618

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 20, 2024

n8n    Run #8013

Run Properties:  status check passed Passed #8013  •  git commit c58b3e673f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-2010-community-issue-readwrite-files-from-disk-node-fails-to
Run status status check passed Passed #8013
Run duration 04m 38s
Commit git commit c58b3e673f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 478
View all changes introduced in this branch ↗︎

…community-issue-readwrite-files-from-disk-node-fails-to
Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 285534e into master Nov 20, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-2010-community-issue-readwrite-files-from-disk-node-fails-to branch November 20, 2024 13:48
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with n8n@1.69.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No binary data returned in Read/Write Files from Disk
3 participants