Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add documentation link to insufficient quota message #11777

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

igatanasov
Copy link
Contributor

@igatanasov igatanasov commented Nov 18, 2024

Summary

Add a “Learn more” link to the “Insufficient quota detected” message for resolving this issue.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-2799/add-link-to-docs-on-error-toast

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 18, 2024
@igatanasov igatanasov force-pushed the ado-2799-add-link-to-docs-on-error-toast branch from ac88517 to a981fa3 Compare November 18, 2024 21:19
@igatanasov igatanasov requested a review from tomi November 18, 2024 21:19
@igatanasov igatanasov self-assigned this Nov 18, 2024
@igatanasov igatanasov requested review from mutdmour and tomi November 19, 2024 15:13
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cypress bot commented Nov 19, 2024

n8n    Run #7987

Run Properties:  status check passed Passed #7987  •  git commit 8bc526920f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
Project n8n
Branch Review ado-2799-add-link-to-docs-on-error-toast
Run status status check passed Passed #7987
Run duration 04m 39s
Commit git commit 8bc526920f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
Committer Ivan Atanasov
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 475
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@igatanasov igatanasov merged commit 1987363 into master Nov 19, 2024
57 checks passed
@igatanasov igatanasov deleted the ado-2799-add-link-to-docs-on-error-toast branch November 19, 2024 15:28
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
@janober
Copy link
Member

janober commented Nov 20, 2024

Got released with n8n@1.69.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants